Skip to content

Lock file format to minimize conflicts #1066

Open
@alexdlm

Description

@alexdlm

What happened?

My repos have constantly conflicting version.locks, particularly exacerbated by various excavators racing each other. The CI expense alone must be high, plus I have to waste my time managing all these PRs.

Less frequently, versions.props conflicts as well, but at least that's within my power to manage to minimize these by separating the more frequently changing deps.

What did you want to happen?

#1001 had a go at adding three comments to space the lock lines out. Can this be (spiritually) revived, or at least the way forward determined?

@gluxon pushed through a similar change to pnpm (pnpm/pnpm#5091) which has since become default. Could we adopt similar inline format here? I'm not a fan of the empty comments from #1001, but perhaps one of these ticks the box for git and is functional?

Option 1

ch.qos.logback:logback-classic:1.2.3
  constraints: 1
  hash: 0805f935

org.slf4j:slf4j-api:1.7.25
  constraints: 1
  hash: 400d4d2a

(Actually this might still trip git up 🤔)

Option 2

ch.qos.logback:logback-classic
  1.2.3 (1 constraints: 0805f935)

org.slf4j:slf4j-api
  1.7.25 (1 constraints: 400d4d2a)

Trivial regex to match the old one line format and this two line format.


I'm happy to make a PR if we can reach a consensus.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions