Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Periodic health check source could use health check source internally #72

Open
andybradshaw opened this issue Apr 25, 2019 · 1 comment

Comments

@andybradshaw
Copy link
Contributor

I've got a use case for a health check that I would like to have refresh periodically in some background thread, but have the actual endpoint use some cached value of this check. I saw that there's a periodic package that almost does what I want. I'm wondering if it would make sense to update this package to take a status.HealthCheckSource instead of the current poll function? This would give people control over the parameters fields of the health check result, which can be useful for supplementing the health state.

@andybradshaw andybradshaw changed the title Periodic health check source should use health check source internally Periodic health check source could use health check source internally Apr 25, 2019
@gregakinman
Copy link

@andybradshaw I think the latest changes should get you what you want

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants