Skip to content

Conversation

@txjas99
Copy link

@txjas99 txjas99 commented Nov 25, 2025

  • Introduced MemoryRateLimiter for managing request limits.
  • Added configuration options for enabling rate limiting and setting request limits and time windows.
  • Implemented methods to enforce rate limits and build rate limit keys based on request context.
  • Integrated rate limiting checks into the request handling process.

txjas99 and others added 2 commits November 25, 2025 22:08
- Introduced MemoryRateLimiter for managing request limits.
- Added configuration options for enabling rate limiting and setting request limits and time windows.
- Implemented methods to enforce rate limits and build rate limit keys based on request context.
- Integrated rate limiting checks into the request handling process.
@ThiefMaster
Copy link
Member

there are already extensions like flask-limiter for this...

@ThiefMaster
Copy link
Member

Looking at the name of your branch: Is this some kind of university/school project where you were asked to make a contribution to a project on GitHub?

@txjas99
Copy link
Author

txjas99 commented Nov 26, 2025

Looking at the name of your branch: Is this some kind of university/school project where you were asked to make a contribution to a project on GitHub?

Yes, and we were asked to contribute to a big library but I don't think any of us really know how to or what contributions to make.

@davidism
Copy link
Member

Please convey to your teacher that this is not an acceptable way to promote open source contribution. They need to properly set you up for success, rather than hoping you figure it out. This was not a good use of maintainer time.

@txjas99
Copy link
Author

txjas99 commented Nov 28, 2025

Please convey to your teacher that this is not an acceptable way to promote open source contribution. They need to properly set you up for success, rather than hoping you figure it out. This was not a good use of maintainer time.

Yes I will do that, my sincere apologies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants