Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "status" field to recipe_id logging #30

Open
cisaacstern opened this issue Sep 19, 2022 · 2 comments · May be fixed by #34
Open

Add "status" field to recipe_id logging #30

cisaacstern opened this issue Sep 19, 2022 · 2 comments · May be fixed by #34

Comments

@cisaacstern
Copy link
Member

As noted in pangeo-forge/pangeo-forge-orchestrator#132, the lack of a "status" field in

pangeo-forge-runner/pangeo_forge_runner/commands/bake.py

Line 117 in 36380ff

self.log.info(f"Baking only recipe_id='{self.recipe_id}'")

causes problems for orchestrator error handling. (This omission was my oversight in #14.)

We should add {"status": "running"} here. And maybe a test/check to make sure log lines always have a "status"?
@yuvipanda
Copy link
Collaborator

@cisaacstern i think if we can establish a baseline JSON scheme for the output lines, beginning with just enforcing existence of status field - that would be awesome

@cisaacstern
Copy link
Member Author

@yuvipanda that sounds great.

How do you recommend writing the JSON schema? (Will this live in a file in this repo? If so, what type of file?)

And once we have it, how to do we ensure compliance for log lines?

@cisaacstern cisaacstern linked a pull request Sep 30, 2022 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure status field in every log line pangeo-forge/pangeo-forge-runner
2 participants
@yuvipanda @cisaacstern