-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Open
Labels
A-engineRelated to the engine implementationRelated to the engine implementationC-perfA change motivated by improving speed, memory usage or disk footprintA change motivated by improving speed, memory usage or disk footprint
Description
Summary
There are two implementations of state_provider_builder that could be deduplicated.
reth/crates/engine/tree/src/tree/mod.rs
Line 2483 in 4231f4b
| match self.state_provider_builder(block_id.parent) { |
| ensure_ok!(self.state_provider_builder(parent_hash, ctx.state())) |
Solution
Instead of discarding the state_provider_builder here
reth/crates/engine/tree/src/tree/mod.rs
Line 2483 in 4231f4b
| match self.state_provider_builder(block_id.parent) { |
execute closure inside the ctx reth/crates/engine/tree/src/tree/mod.rs
Line 2523 in 4231f4b
| let executed = execute(&mut self.payload_validator, input, ctx)?; |
reth/crates/engine/tree/src/tree/payload_validator.rs
Lines 364 to 365 in 4231f4b
| let Some(provider_builder) = | |
| ensure_ok!(self.state_provider_builder(parent_hash, ctx.state())) |
Metadata
Metadata
Assignees
Labels
A-engineRelated to the engine implementationRelated to the engine implementationC-perfA change motivated by improving speed, memory usage or disk footprintA change motivated by improving speed, memory usage or disk footprint
Type
Projects
Status
Backlog