Skip to content

Update annotate_snippets emitter #592

@DaniPopes

Description

@DaniPopes

Describe the feature

Upstream has updated to latest annotate_snippets version:

https://github.com/rust-lang/rust/blob/4146079cee94242771864147e32fb5d9adbd34f8/compiler/rustc_errors/src/annotate_snippet_emitter_writer.rs

Before, it was heavily outdated so I wrote the rust-like diagnostic -> annotate_snippets conversion myself, but this has a few subtle bugs and might not have the best output.

Our diagnostics are mostly the same as in Rust, so we should be able to replace this conversion to the one that is now in Rust upstream without too much issue.

Additional context

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-interfaceArea: interfaceC-cleanupCategory: PRs that clean code up or issues documenting cleanupC-enhancementCategory: an issue proposing an enhancement or a PR with oneE-mediumCall for participation: Medium difficulty. Experience needed to fix: Intermediate.P-mediumMedium priority

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions