Skip to content

InvalidCharacterError: Failed to execute 'atob' on 'Window' #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zfi opened this issue Mar 5, 2020 · 2 comments
Closed

InvalidCharacterError: Failed to execute 'atob' on 'Window' #341

zfi opened this issue Mar 5, 2020 · 2 comments
Assignees
Labels
bug Something isn't working deployment/staged Issue is pending in staged code. Ready for verification when deployed. Verified The reported issue has been mitigated

Comments

@zfi
Copy link
Contributor

zfi commented Mar 5, 2020

Reported from Sentry: The string to be decoded is not correctly encoded.
in /src/blocklypropclient.js:386:30

            else if (ws_msg.type === 'serial-terminal' &&
                    (typeof ws_msg.msg === 'string' || ws_msg.msg instanceof String)) {
                // sometimes some weird stuff comes through...
                // type: 'serial-terminal'
                // msg: [String Base64-encoded message]

                var msg_in = atob(ws_msg.msg);    <<===============

                if (term !== null) { // is the terminal open?

Chome OS 12607.82.0
Chrome 79.0.3945
URL: solo.parallax.com/blocklyc.html

The sequence of events look like a binary payload was received, then the user closed a modal in the vicinity of <div #serial_console.prop-term.propTerm...>. The error occurred immediately after the user clicked the close button.

@zfi zfi added the bug Something isn't working label Mar 5, 2020
@zfi zfi added this to the v1.4.3 Release milestone Mar 5, 2020
@MatzElectronics
Copy link
Collaborator

MatzElectronics commented Mar 5, 2020 via email

@pjewald pjewald added the task/verify Bug or feature is ready to be tested and verified label Mar 5, 2020
@pjewald
Copy link
Collaborator

pjewald commented Mar 5, 2020

Addresses in PR #337 but needs to be verified.

@zfi zfi added the deployment/staged Issue is pending in staged code. Ready for verification when deployed. label Mar 5, 2020
@zfi zfi added Verified The reported issue has been mitigated and removed task/verify Bug or feature is ready to be tested and verified labels Jun 19, 2020
@zfi zfi closed this as completed Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working deployment/staged Issue is pending in staged code. Ready for verification when deployed. Verified The reported issue has been mitigated
Projects
None yet
Development

No branches or pull requests

3 participants