Skip to content

address: Create common functionality to remove code duplicate #337

New issue
New issue
Open
#394
Open
address: Create common functionality to remove code duplicate#337
#394
Labels
priority: lowNice-to-have improvements, optimizations, or future considerationstodoExtracted from code todos
@lexnv

Description

@lexnv
lexnv
opened on Feb 27, 2025

This pattern is implemented in multiple places:

litep2p/src/protocol/libp2p/kademlia/routing_table.rs

Lines 145 to 156 in e0b7118

// TODO: this has to be moved elsewhere at some point
let addresses: Vec<Multiaddr> = addresses
.into_iter()
.filter_map(|address| {
let last = address.iter().last();
if std::matches!(last, Some(Protocol::P2p(_))) {
Some(address)
} else {
Some(address.with(Protocol::P2p(Multihash::from_bytes(&peer.to_bytes()).ok()?)))
}
})
.collect();

Metadata

Metadata

Assignees

No one assigned

    Labels

    priority: lowNice-to-have improvements, optimizations, or future considerationstodoExtracted from code todos

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions