Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Sebastian Kunert <[email protected]>
Co-authored-by: Michal Kucharczyk <[email protected]>
  • Loading branch information
3 people authored Oct 23, 2024
1 parent 161abb6 commit cf1e7f5
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion docs/sdk/src/guides/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
//! * [`your_first_runtime`], where you learn how to compile your pallets into a WASM runtime.
//! * [`your_first_node`], where you learn how to run the said runtime in a node.
//!
//! > By this step, you have already launched a full Polkadot-Sdk-based blockchain!
//! > By this step, you have already launched a full Polkadot-SDK-based blockchain!
//!
//! Once done, feel free to step up into one of our templates: [`crate::polkadot_sdk::templates`].
//!
Expand Down
8 changes: 4 additions & 4 deletions docs/sdk/src/guides/your_first_runtime.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
//! A runtime shares a few similar setup requirements as with a pallet:
//!
//! * importing [`frame`], [`codec`], and [`scale_info`] crates.
//! * following the [`std`](crate::polkadot_sdk::substrate#wasm-build) pattern.
//! * following the [`std` feature-gating](crate::polkadot_sdk::substrate#wasm-build) pattern.
//!
//! But, more specifically, it also contains:
//!
Expand All @@ -34,7 +34,7 @@
#![doc = docify::embed!("./packages/guides/first-runtime/src/lib.rs", VERSION)]
//!
//! The version contains a number of very important fields, such as `spec_version` and `spec_name`
//! that play an important role in identifying your runtime and its version. More about runtime
//! that play an important role in identifying your runtime and its version, more importantly in runtime upgrades. More about runtime
//! upgrades in [`crate::reference_docs::frame_runtime_upgrades_and_migrations`].
//!
//! Then, a real runtime also contains the `impl` of all individual pallets' `trait Config` for
Expand All @@ -53,7 +53,7 @@
//! [`frame::prelude::frame_system::pallet::config_preludes`]) to learn more which types are exactly
//! used.
//!
//! Recall that in [`crate::guides::your_first_pallet`], we provided `type AccountId = u64` to
//! Recall that in test runtime in [`crate::guides::your_first_pallet`], we provided `type AccountId = u64` to
//! `frame_system`, while in this case we rely on whatever is provided by
//! [`SolochainDefaultConfig`], which is indeed a "real" 32 byte account id.
//!
Expand Down Expand Up @@ -99,7 +99,7 @@
//! And that more or less covers the details of how you would write a real runtime!
//!
//! Once you compile a crate that contains a runtime as above, simply running `cargo build` will
//! generate the wasm blobs and place them under `./target/wbuild`, as explained
//! generate the wasm blobs and place them under `./target/release/wbuild`, as explained
//! [here](crate::polkadot_sdk::substrate#wasm-build).
//!
//! ## Genesis Configuration
Expand Down
2 changes: 1 addition & 1 deletion docs/sdk/src/reference_docs/frame_benchmarking_weight.rs
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@
//!
//! Two ways exist to run the benchmarks of a runtime.
//!
//! 1. The old school way: Most Polkadot-Sdk based nodes (such as the ones integrated in
//! 1. The old school way: Most Polkadot-SDK based nodes (such as the ones integrated in
//! [`templates`]) have an a `benchmark` subcommand integrated into themselves.
//! 2. The more [`crate::reference_docs::omni_node`] compatible way of running the benchmarks would
//! be using [`frame-omni-bencher`] CLI, which only relies on a runtime.
Expand Down

0 comments on commit cf1e7f5

Please sign in to comment.