Skip to content

Commit cf1e7f5

Browse files
kianenigmaskunertmichalkucharczyk
authored
Apply suggestions from code review
Co-authored-by: Sebastian Kunert <[email protected]> Co-authored-by: Michal Kucharczyk <[email protected]>
1 parent 161abb6 commit cf1e7f5

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

docs/sdk/src/guides/mod.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
//! * [`your_first_runtime`], where you learn how to compile your pallets into a WASM runtime.
1111
//! * [`your_first_node`], where you learn how to run the said runtime in a node.
1212
//!
13-
//! > By this step, you have already launched a full Polkadot-Sdk-based blockchain!
13+
//! > By this step, you have already launched a full Polkadot-SDK-based blockchain!
1414
//!
1515
//! Once done, feel free to step up into one of our templates: [`crate::polkadot_sdk::templates`].
1616
//!

docs/sdk/src/guides/your_first_runtime.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
//! A runtime shares a few similar setup requirements as with a pallet:
1111
//!
1212
//! * importing [`frame`], [`codec`], and [`scale_info`] crates.
13-
//! * following the [`std`](crate::polkadot_sdk::substrate#wasm-build) pattern.
13+
//! * following the [`std` feature-gating](crate::polkadot_sdk::substrate#wasm-build) pattern.
1414
//!
1515
//! But, more specifically, it also contains:
1616
//!
@@ -34,7 +34,7 @@
3434
#![doc = docify::embed!("./packages/guides/first-runtime/src/lib.rs", VERSION)]
3535
//!
3636
//! The version contains a number of very important fields, such as `spec_version` and `spec_name`
37-
//! that play an important role in identifying your runtime and its version. More about runtime
37+
//! that play an important role in identifying your runtime and its version, more importantly in runtime upgrades. More about runtime
3838
//! upgrades in [`crate::reference_docs::frame_runtime_upgrades_and_migrations`].
3939
//!
4040
//! Then, a real runtime also contains the `impl` of all individual pallets' `trait Config` for
@@ -53,7 +53,7 @@
5353
//! [`frame::prelude::frame_system::pallet::config_preludes`]) to learn more which types are exactly
5454
//! used.
5555
//!
56-
//! Recall that in [`crate::guides::your_first_pallet`], we provided `type AccountId = u64` to
56+
//! Recall that in test runtime in [`crate::guides::your_first_pallet`], we provided `type AccountId = u64` to
5757
//! `frame_system`, while in this case we rely on whatever is provided by
5858
//! [`SolochainDefaultConfig`], which is indeed a "real" 32 byte account id.
5959
//!
@@ -99,7 +99,7 @@
9999
//! And that more or less covers the details of how you would write a real runtime!
100100
//!
101101
//! Once you compile a crate that contains a runtime as above, simply running `cargo build` will
102-
//! generate the wasm blobs and place them under `./target/wbuild`, as explained
102+
//! generate the wasm blobs and place them under `./target/release/wbuild`, as explained
103103
//! [here](crate::polkadot_sdk::substrate#wasm-build).
104104
//!
105105
//! ## Genesis Configuration

docs/sdk/src/reference_docs/frame_benchmarking_weight.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@
9595
//!
9696
//! Two ways exist to run the benchmarks of a runtime.
9797
//!
98-
//! 1. The old school way: Most Polkadot-Sdk based nodes (such as the ones integrated in
98+
//! 1. The old school way: Most Polkadot-SDK based nodes (such as the ones integrated in
9999
//! [`templates`]) have an a `benchmark` subcommand integrated into themselves.
100100
//! 2. The more [`crate::reference_docs::omni_node`] compatible way of running the benchmarks would
101101
//! be using [`frame-omni-bencher`] CLI, which only relies on a runtime.

0 commit comments

Comments
 (0)