Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run_all_benchmarks.sh script fails for asset-conversion-ops pallet #6160

Closed
2 tasks done
re-gius opened this issue Oct 21, 2024 · 1 comment
Closed
2 tasks done

run_all_benchmarks.sh script fails for asset-conversion-ops pallet #6160

re-gius opened this issue Oct 21, 2024 · 1 comment
Assignees
Labels
C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. I2-bug The node fails to follow expected behavior. I10-unconfirmed Issue might be valid, but it's not yet known. T2-pallets This PR/Issue is related to a particular pallet.

Comments

@re-gius
Copy link
Contributor

re-gius commented Oct 21, 2024

Is there an existing issue?

  • I have searched the existing issues

Experiencing problems? Have you tried our Stack Exchange first?

  • This is not a support question.

Description of bug

The run_all_benchmarks.sh script fails for the asset-conversion-ops pallet because it tries to create a weight file inside of a /frame/asset-conversion-ops/src/ folder which doesn't exist. The asset-conversion-ops pallet is defined inside of the /frame/asset-conversion/ops/src/ folder instead.
The reported error is Error: Input("Could not write weight file to: \"./frame/asset-conversion-ops/src/weights.rs\". Error: Os { code: 2, kind: NotFound, message: \"No such file or directory\" }").

The error comes from the implicit assumption in the script that every pallet with name <pallet_name> is defined inside the /frame/<pallet_name>/src/ folder.

Possible solution: handle the asset-conversion-ops pallet separately, overring the FOLDER variable with asset-conversion/ops. This would solve the issue, but it may be sensitive to possible future changes to the pallet.

Steps to reproduce

cd substrate
bash scripts/run_all_benchmarks.sh
@re-gius re-gius added I2-bug The node fails to follow expected behavior. I10-unconfirmed Issue might be valid, but it's not yet known. T2-pallets This PR/Issue is related to a particular pallet. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. labels Oct 21, 2024
@re-gius re-gius self-assigned this Oct 21, 2024
re-gius added a commit that referenced this issue Oct 21, 2024
@re-gius
Copy link
Contributor Author

re-gius commented Oct 29, 2024

Solved in #5995

@re-gius re-gius closed this as completed Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. I2-bug The node fails to follow expected behavior. I10-unconfirmed Issue might be valid, but it's not yet known. T2-pallets This PR/Issue is related to a particular pallet.
Projects
None yet
Development

No branches or pull requests

1 participant