Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pallet broker: some benchmarks are weightless for kitchensink runtime. Resulting in substrate weight being 0 #6474

Open
gui1117 opened this issue Nov 14, 2024 · 1 comment · May be fixed by #6505
Labels
T12-benchmarks This PR/Issue is related to benchmarking and weights.

Comments

@gui1117
Copy link
Contributor

gui1117 commented Nov 14, 2024

enable_auto_renew and disable_auto_renew benchmarks result in Weightless when run against the kitchensink runtime. And also when run against the mock runtime.

It is not very ideal as we use kitchen sink to get some default weight and some general idea of the cost of the pallet calls.

You can see the weight info resulting from CI here: 4dfe581#diff-394c3120033a81905e5460398ad0d7245d7143d21069aeffb3cdf07b41eccc18

I believe it is weightless since: #4424

@Szegoo
@seadanda

@gui1117 gui1117 added the T12-benchmarks This PR/Issue is related to benchmarking and weights. label Nov 14, 2024
@seadanda
Copy link
Contributor

Yea the benchmark is broken - the prices are too low for the purchases. Working on a fix.

@seadanda seadanda linked a pull request Nov 15, 2024 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T12-benchmarks This PR/Issue is related to benchmarking and weights.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants