Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Themes #12

Open
cassidyjames opened this issue Nov 1, 2017 · 5 comments
Open

Themes #12

cassidyjames opened this issue Nov 1, 2017 · 5 comments

Comments

@cassidyjames
Copy link

It would be handy to have a simple theme chooser with light, dark, and parchment (the current) theme choices. This could look similar to how Bookwork handles themes, and how we've talked about doing a theme toggle for both Terminal and Scratch.

Something like the circular color picker here:

iOS screenshot

...but with the three options (light, dark, and parchment).

@micahilbery
Copy link
Contributor

I threw together some backgrounds and compiled the code with each of them. Although I don't know how to properly change stuff because I'm not really familiar with vala you can get the gist of what the themes might look like.
sudoku_themes

@parnoldx
Copy link
Owner

parnoldx commented Jan 4, 2018

For the dark mode the red looks imo strange. So this should propably also change with the theme. Any suggestion?

@micahilbery
Copy link
Contributor

Yeah this was just a quick change of the background and recompile. I would have changed the colours of the text, numbers, and grids for each theme but idk how to change the code for it. I was planning on working on a few mockups of the themes and play around with the colours to see what would look best but haven't gotten to it yet.

@parnoldx
Copy link
Owner

parnoldx commented Jan 4, 2018

Mokup would be great. I do the coding

@cassidyjames
Copy link
Author

As an update to this, both Terminal and Code now have quick style switchers, which would be a good pattern for this.

screenshot from 2018-03-24 13 31 53
screenshot from 2018-03-24 13 31 45
screenshot from 2018-03-24 13 31 34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants