Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Remove connectionRetryLimit from documentation and options (it is not used) #146

Open
titanism opened this issue Aug 5, 2024 · 2 comments · May be fixed by #164
Open

Bug: Remove connectionRetryLimit from documentation and options (it is not used) #146

titanism opened this issue Aug 5, 2024 · 2 comments · May be fixed by #164
Labels
type:bug

Comments

@titanism
Copy link

titanism commented Aug 5, 2024

The option connectionRetryLimit is not used anywhere in the codebase, but it's documented as an option:

https://github.com/search?q=repo%3Aparse-community%2Fnode-apn+connectionRetryLimit&type=code
@parse-github-assistant Parse GitHub Assistant
Copy link

Thanks for opening this issue!

@cbaker6
Copy link

cbaker6 commented Jan 2, 2025

I don't think you should remove the option, just needs to be used in the client

@cbaker6 cbaker6 linked a pull request Jan 2, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add the ability to manage channels and send broadcasts cbaker6/node-apn
3 participants
@mtrezza @cbaker6 @titanism