Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[V1] Add nullable default fields to AST node factories #1640

Open
RCHowell opened this issue Nov 4, 2024 · 0 comments
Open

[V1] Add nullable default fields to AST node factories #1640

RCHowell opened this issue Nov 4, 2024 · 0 comments
Labels
enhancement New feature or request V1 This is related to the V1 release of PartiQL.

Comments

@RCHowell
Copy link
Contributor

RCHowell commented Nov 4, 2024

Description

when converting the SqlDialectTest over to use the v1 AST, it was somewhat annoying to not have defaults for all of the nullable fields. Deferring adding defaults to a different PR since we'll need to examine backwards compatibility of defaults a bit further.

#1638
@RCHowell RCHowell added enhancement New feature or request V1 This is related to the V1 release of PartiQL. labels Nov 4, 2024
@RCHowell RCHowell mentioned this issue Nov 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request V1 This is related to the V1 release of PartiQL.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RCHowell