Skip to content

Conversation

@jjppp
Copy link
Member

@jjppp jjppp commented Sep 4, 2025

This PR configures checkstyle to issue errors instead of warnings when codeing-style violations are detected in GitHub CI, as in this CI run, and fixes a coding-style violation related to the license header of a test driver.

@codecov
Copy link

codecov bot commented Sep 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.78%. Comparing base (064801b) to head (084c152).

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #202   +/-   ##
=========================================
  Coverage     75.78%   75.78%           
  Complexity     4659     4659           
=========================================
  Files           481      481           
  Lines         16055    16055           
  Branches       2198     2198           
=========================================
  Hits          12167    12167           
+ Misses         3020     3019    -1     
- Partials        868      869    +1     

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zhangt2333
Copy link
Member

zhangt2333 commented Sep 4, 2025

Currently, the checkstyle warnings are not natively reported by checkstyle itself - I wrote a utility class to format and output them.

doLast { summarizeStyleViolations(this as Checkstyle)?.let(logger::warn) }

In this PR, directly enabling checkstyle's option would actually suppress our style violation reporting.

My suggestion is that we have another approach to report style violations in PR comments, such as reviewdog.

@jjppp jjppp marked this pull request as draft September 5, 2025 06:35
@jjppp
Copy link
Member Author

jjppp commented Sep 5, 2025

Will do this with a better tool such as review dog, closing.

@jjppp jjppp closed this Sep 5, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Sep 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants