-
Notifications
You must be signed in to change notification settings - Fork 370
Description
Describe the problem
It looks like the label wrapping the input in SelectColumn
, which was originally added in PatternFly 4 to increase the clickable area, no longer seems to have any effect in PatternFly 6:
<label> |
How do you reproduce the problem?
Visit https://www.patternfly.org/components/table#selectable-radio-input and try clicking just outside but near the radio input. It doesn’t get selected.
Then compare this behavior with the archived PatternFly 4 version at https://v4-archive.patternfly.org/v4/components/table#composable-selectable-radio-input. Here, clicking in the surrounding "column area" does select the radio input, and the cursor style differs as well.
Expected behavior
Not entirely sure what the behavior should be, but I personally lean toward increasing the actual input size as somehow mentioned in
patternfly/patternfly#4546 (comment)
In my view, making native elements more prominent feels more appropiated than using a transparent label to expand the clickable area, which could be unexpected regarding to native behavior.
Is this issue blocking you?
Not at all. Just noticed this while reviewing the code and was curious about the intention behind such a wrapping label.
Any other information?
Such a label was added at #6754 in patternfly-react package after previously added at patternfly/patternfly#4546 in patternfly package.
Metadata
Metadata
Assignees
Labels
Type
Projects
Status