Skip to content

Animations codemod - separate table as its own rule #847

Open
@thatblindgeye

Description

@thatblindgeye

From discussion of animations issues arising in product, we should update the current animations codemod so that there are 2 rules that must be manually run with the --only flag:

  1. The existing codemod as it is, except remove Table from the rule
  2. A new rule that only updates Tables to add the hasAnimations prop, and only when the Table is an expandable table (may have to check if at least 1 child of the table or the Table itself has isExpanded or a new propr isContentExpanded for this).

Alternatively, a nice-to-have that was mentioned during platform topics today was a CLI for the existing animations rule, where you select what components you want to opt into animations for. cc @wise-king-sullyman can explain better in case I missed anything/am off on what the idea is.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    Status

    Needs triage

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions