Improve timer duration button states

Author: patzly

app/src/main/java/xyz/zedler/patrick/tack/Constants.java

@@ -31,7 +31,7 @@ public final class Constants {
   public static final int BEATS_MAX = 20;
   public static final int SUBS_MAX = 10;
   public static final int BOOKMARKS_MAX = 10;
-  public static final int TIMER_MAX = 400;
+  public static final int TIMER_MAX = 399;
 
   public final static class PREF {
     // General

app/src/main/java/xyz/zedler/patrick/tack/util/OptionsUtil.java

@@ -269,26 +269,28 @@ private void updateTimer() {
     int valueTo = (int) binding.sliderOptionsTimerDuration.getValueTo();
     int range = valueTo - valueFrom;
 
-    binding.buttonOptionsTimerDecrease.setEnabled(timerDuration >= range);
+    // Calculate current range
+    int factor = timerDuration / (range + 1);
+    int valueFromNew = factor * (range + 1);
+    int valueToNew = valueFromNew + range;
+
+    binding.buttonOptionsTimerDecrease.setEnabled(valueFromNew > 0);
     binding.buttonOptionsTimerDecrease.setOnClickListener(this);
     ViewCompat.setTooltipText(
         binding.buttonOptionsTimerDecrease,
         activity.getString(R.string.action_decrease)
     );
 
-    binding.buttonOptionsTimerIncrease.setEnabled(timerDuration < Constants.TIMER_MAX);
+    binding.buttonOptionsTimerIncrease.setEnabled(valueToNew < Constants.TIMER_MAX);
     binding.buttonOptionsTimerIncrease.setOnClickListener(this);
     ViewCompat.setTooltipText(
         binding.buttonOptionsTimerIncrease,
         activity.getString(R.string.action_increase)
     );
 
-    // Calculate current range
-    int factor = timerDuration / (range + 1);
-    int valueFromNew = factor * (range + 1);
     binding.sliderOptionsTimerDuration.removeOnChangeListener(this);
     binding.sliderOptionsTimerDuration.setValueFrom(valueFromNew);
-    binding.sliderOptionsTimerDuration.setValueTo(valueFromNew + range);
+    binding.sliderOptionsTimerDuration.setValueTo(valueToNew);
     binding.sliderOptionsTimerDuration.setValue(timerDuration);
     binding.sliderOptionsTimerDuration.addOnChangeListener(this);
     binding.sliderOptionsTimerDuration.setLabelFormatter(value -> {

app/src/main/res/raw/changelog.txt

@@ -2,6 +2,7 @@
 
 - New: option to highlight current beat
 - Improved: controls appearance on main screen
+- Improved: timer duration now up to 399 units with new increase/decrease buttons
 - Fixed: vibration not working on some devices
 - Fixed: various crashes and bugs on lower Android versions