Skip to content

Commit f52d3a0

Browse files
committed
Format shell scripts.
1 parent 724fa60 commit f52d3a0

File tree

4 files changed

+236
-238
lines changed

4 files changed

+236
-238
lines changed

tools/internal_ci/linux/grpc_e2e_performance_gke.sh

Lines changed: 61 additions & 62 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ cd "$(dirname "$0")/../../.."
1919

2020
source tools/internal_ci/helper_scripts/prepare_build_linux_rc
2121

22-
2322
# Environment variables to select repos and branches for various repos.
2423
# You can edit these lines if you want to run from a fork.
2524
GRPC_CORE_REPO=grpc/grpc
@@ -43,20 +42,20 @@ gcloud auth configure-docker
4342
# Connect to benchmarks-prod2 cluster.
4443
gcloud config set project grpc-testing
4544
gcloud container clusters get-credentials benchmarks-prod2 \
46-
--zone us-central1-b --project grpc-testing
45+
--zone us-central1-b --project grpc-testing
4746

4847
# Set up environment variables.
4948
LOAD_TEST_PREFIX="${KOKORO_BUILD_INITIATOR}"
5049
# BEGIN differentiate experimental configuration from master configuration.
5150
if [[ "${KOKORO_BUILD_INITIATOR%%-*}" == kokoro && "${KOKORO_GITHUB_COMMIT_URL%/*}" == "https://github.com/grpc/grpc/commit" ]]; then
52-
# Use "official" BQ tables only for builds initiated by Kokoro and running
53-
# from grpc/grpc. These results show up in the "official" public dashboard.
54-
BIGQUERY_TABLE_8CORE=e2e_benchmarks.ci_master_results_8core
55-
BIGQUERY_TABLE_32CORE=e2e_benchmarks.ci_master_results_32core
51+
# Use "official" BQ tables only for builds initiated by Kokoro and running
52+
# from grpc/grpc. These results show up in the "official" public dashboard.
53+
BIGQUERY_TABLE_8CORE=e2e_benchmarks.ci_master_results_8core
54+
BIGQUERY_TABLE_32CORE=e2e_benchmarks.ci_master_results_32core
5655
else
57-
# Use experimental BQ tables otherwise.
58-
BIGQUERY_TABLE_8CORE=e2e_benchmarks.experimental_results
59-
BIGQUERY_TABLE_32CORE=e2e_benchmarks.experimental_results_32core
56+
# Use experimental BQ tables otherwise.
57+
BIGQUERY_TABLE_8CORE=e2e_benchmarks.experimental_results
58+
BIGQUERY_TABLE_32CORE=e2e_benchmarks.experimental_results_32core
6059
fi
6160
# END differentiate experimental configuration from master configuration.
6261
CLOUD_LOGGING_URL="https://source.cloud.google.com/results/invocations/${KOKORO_BUILD_ID}"
@@ -67,9 +66,9 @@ ROOT_DIRECTORY_OF_DOCKERFILES="../test-infra/containers/pre_built_workers/"
6766
GRPC_COMMIT="$(git show --format="%H" --no-patch)"
6867
# Prebuilt workers for core languages are always built from grpc/grpc.
6968
if [[ "${KOKORO_GITHUB_COMMIT_URL%/*}" == "https://github.com/grpc/grpc/commit" ]]; then
70-
GRPC_CORE_COMMIT="${KOKORO_GIT_COMMIT}"
69+
GRPC_CORE_COMMIT="${KOKORO_GIT_COMMIT}"
7170
else
72-
GRPC_CORE_COMMIT="$(git ls-remote -h "https://github.com/${GRPC_CORE_REPO}.git" "${GRPC_CORE_GITREF}" | cut -f1)"
71+
GRPC_CORE_COMMIT="$(git ls-remote -h "https://github.com/${GRPC_CORE_REPO}.git" "${GRPC_CORE_GITREF}" | cut -f1)"
7372
fi
7473

7574
GRPC_DOTNET_COMMIT="$(git ls-remote "https://github.com/${GRPC_DOTNET_REPO}.git" "${GRPC_DOTNET_GITREF}" | cut -f1)"
@@ -94,30 +93,30 @@ popd
9493

9594
# Build test configurations.
9695
buildConfigs() {
97-
local -r pool="$1"
98-
local -r table="$2"
99-
shift 2
100-
tools/run_tests/performance/loadtest_config.py "$@" \
101-
-t ./tools/run_tests/performance/templates/loadtest_template_prebuilt_all_languages.yaml \
102-
-s driver_pool="${DRIVER_POOL}" -s driver_image= \
103-
-s client_pool="${pool}" -s server_pool="${pool}" \
104-
-s big_query_table="${table}" -s timeout_seconds=900 \
105-
-s prebuilt_image_prefix="${PREBUILT_IMAGE_PREFIX}" \
106-
-s prebuilt_image_tag="${UNIQUE_IDENTIFIER}" \
107-
-a ci_buildNumber="${KOKORO_BUILD_NUMBER}" \
108-
-a ci_buildUrl="${CLOUD_LOGGING_URL}" \
109-
-a ci_jobName="${KOKORO_JOB_NAME}" \
110-
-a ci_gitCommit="${GRPC_COMMIT}" \
111-
-a ci_gitCommit_core="${GRPC_CORE_COMMIT}" \
112-
-a ci_gitCommit_dotnet="${GRPC_DOTNET_COMMIT}" \
113-
-a ci_gitCommit_go="${GRPC_GO_COMMIT}" \
114-
-a ci_gitCommit_java="${GRPC_JAVA_COMMIT}" \
115-
-a ci_gitActualCommit="${KOKORO_GIT_COMMIT}" \
116-
--prefix="${LOAD_TEST_PREFIX}" -u "${UNIQUE_IDENTIFIER}" -u "${pool}" \
117-
-a pool="${pool}" --category=scalable \
118-
--allow_client_language=c++ --allow_server_language=c++ \
119-
--allow_server_language=node \
120-
-o "loadtest_with_prebuilt_workers_${pool}.yaml"
96+
local -r pool="$1"
97+
local -r table="$2"
98+
shift 2
99+
tools/run_tests/performance/loadtest_config.py "$@" \
100+
-t ./tools/run_tests/performance/templates/loadtest_template_prebuilt_all_languages.yaml \
101+
-s driver_pool="${DRIVER_POOL}" -s driver_image= \
102+
-s client_pool="${pool}" -s server_pool="${pool}" \
103+
-s big_query_table="${table}" -s timeout_seconds=900 \
104+
-s prebuilt_image_prefix="${PREBUILT_IMAGE_PREFIX}" \
105+
-s prebuilt_image_tag="${UNIQUE_IDENTIFIER}" \
106+
-a ci_buildNumber="${KOKORO_BUILD_NUMBER}" \
107+
-a ci_buildUrl="${CLOUD_LOGGING_URL}" \
108+
-a ci_jobName="${KOKORO_JOB_NAME}" \
109+
-a ci_gitCommit="${GRPC_COMMIT}" \
110+
-a ci_gitCommit_core="${GRPC_CORE_COMMIT}" \
111+
-a ci_gitCommit_dotnet="${GRPC_DOTNET_COMMIT}" \
112+
-a ci_gitCommit_go="${GRPC_GO_COMMIT}" \
113+
-a ci_gitCommit_java="${GRPC_JAVA_COMMIT}" \
114+
-a ci_gitActualCommit="${KOKORO_GIT_COMMIT}" \
115+
--prefix="${LOAD_TEST_PREFIX}" -u "${UNIQUE_IDENTIFIER}" -u "${pool}" \
116+
-a pool="${pool}" --category=scalable \
117+
--allow_client_language=c++ --allow_server_language=c++ \
118+
--allow_server_language=node \
119+
-o "loadtest_with_prebuilt_workers_${pool}.yaml"
121120
}
122121

123122
# Add languages
@@ -126,61 +125,61 @@ declare -a configLangArgs32core=()
126125
declare -a runnerLangArgs=()
127126

128127
# c++
129-
configLangArgs8core+=( -l c++ )
130-
configLangArgs32core+=( -l c++ )
131-
runnerLangArgs+=( -l "cxx:${GRPC_CORE_REPO}:${GRPC_CORE_COMMIT}" )
128+
configLangArgs8core+=(-l c++)
129+
configLangArgs32core+=(-l c++)
130+
runnerLangArgs+=(-l "cxx:${GRPC_CORE_REPO}:${GRPC_CORE_COMMIT}")
132131

133132
# dotnet
134133
# configLangArgs8core+=( -l dotnet )
135134
# configLangArgs32core+=( -l dotnet )
136135
# runnerLangArgs+=( -l "dotnet:${GRPC_DOTNET_REPO}:${GRPC_DOTNET_COMMIT}" )
137136

138137
# # go
139-
configLangArgs8core+=( -l go )
140-
configLangArgs32core+=( -l go )
141-
runnerLangArgs+=( -l "go:${GRPC_GO_REPO}:${GRPC_GO_COMMIT}" )
138+
configLangArgs8core+=(-l go)
139+
configLangArgs32core+=(-l go)
140+
runnerLangArgs+=(-l "go:${GRPC_GO_REPO}:${GRPC_GO_COMMIT}")
142141

143142
# java
144-
configLangArgs8core+=( -l java )
145-
configLangArgs32core+=( -l java )
146-
runnerLangArgs+=( -l "java:${GRPC_JAVA_REPO}:${GRPC_JAVA_COMMIT}" )
143+
configLangArgs8core+=(-l java)
144+
configLangArgs32core+=(-l java)
145+
runnerLangArgs+=(-l "java:${GRPC_JAVA_REPO}:${GRPC_JAVA_COMMIT}")
147146

148147
# node
149-
configLangArgs8core+=( -l node ) # 8-core only.
150-
runnerLangArgs+=( -l "node:${GRPC_NODE_REPO}:${GRPC_NODE_COMMIT}" )
148+
configLangArgs8core+=(-l node) # 8-core only.
149+
runnerLangArgs+=(-l "node:${GRPC_NODE_REPO}:${GRPC_NODE_COMMIT}")
151150

152151
# python
153-
configLangArgs8core+=( -l python ) # 8-core only.
154-
runnerLangArgs+=( -l "python:${GRPC_CORE_REPO}:${GRPC_CORE_COMMIT}" )
152+
configLangArgs8core+=(-l python) # 8-core only.
153+
runnerLangArgs+=(-l "python:${GRPC_CORE_REPO}:${GRPC_CORE_COMMIT}")
155154

156155
# ruby
157-
configLangArgs8core+=( -l ruby ) # 8-core only.
158-
runnerLangArgs+=( -l "ruby:${GRPC_CORE_REPO}:${GRPC_CORE_COMMIT}" )
156+
configLangArgs8core+=(-l ruby) # 8-core only.
157+
runnerLangArgs+=(-l "ruby:${GRPC_CORE_REPO}:${GRPC_CORE_COMMIT}")
159158

160159
buildConfigs "${WORKER_POOL_8CORE}" "${BIGQUERY_TABLE_8CORE}" "${configLangArgs8core[@]}"
161160
buildConfigs "${WORKER_POOL_32CORE}" "${BIGQUERY_TABLE_32CORE}" "${configLangArgs32core[@]}"
162161

163162
# Delete prebuilt images on exit.
164163
deleteImages() {
165-
echo "deleting images on exit"
166-
../test-infra/bin/delete_prebuilt_workers \
164+
echo "deleting images on exit"
165+
../test-infra/bin/delete_prebuilt_workers \
167166
-p "${PREBUILT_IMAGE_PREFIX}" \
168167
-t "${UNIQUE_IDENTIFIER}"
169168
}
170169
trap deleteImages EXIT
171170

172171
# Build and push prebuilt images for running tests.
173172
time ../test-infra/bin/prepare_prebuilt_workers "${runnerLangArgs[@]}" \
174-
-p "${PREBUILT_IMAGE_PREFIX}" \
175-
-t "${UNIQUE_IDENTIFIER}" \
176-
-r "${ROOT_DIRECTORY_OF_DOCKERFILES}"
173+
-p "${PREBUILT_IMAGE_PREFIX}" \
174+
-t "${UNIQUE_IDENTIFIER}" \
175+
-r "${ROOT_DIRECTORY_OF_DOCKERFILES}"
177176

178177
# Run tests.
179178
time ../test-infra/bin/runner \
180-
-i "loadtest_with_prebuilt_workers_${WORKER_POOL_8CORE}.yaml" \
181-
-i "loadtest_with_prebuilt_workers_${WORKER_POOL_32CORE}.yaml" \
182-
-log-url-prefix "${LOG_URL_PREFIX}" \
183-
-polling-interval 5s \
184-
-delete-successful-tests \
185-
-c "${WORKER_POOL_8CORE}:2" -c "${WORKER_POOL_32CORE}:2" \
186-
-o "runner/sponge_log.xml"
179+
-i "loadtest_with_prebuilt_workers_${WORKER_POOL_8CORE}.yaml" \
180+
-i "loadtest_with_prebuilt_workers_${WORKER_POOL_32CORE}.yaml" \
181+
-log-url-prefix "${LOG_URL_PREFIX}" \
182+
-polling-interval 5s \
183+
-delete-successful-tests \
184+
-c "${WORKER_POOL_8CORE}:2" -c "${WORKER_POOL_32CORE}:2" \
185+
-o "runner/sponge_log.xml"

tools/internal_ci/linux/grpc_e2e_performance_gke_cxx_experiments_framework.sh

Lines changed: 51 additions & 51 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,9 @@ set -ex
1818
#
1919
# To run the benchmarks, add your experiment to the set below.
2020
declare -a GRPC_EXPERIMENTS=(
21-
"event_engine_listener"
22-
"event_engine_client"
23-
"event_engine_client,event_engine_listener"
21+
"event_engine_listener"
22+
"event_engine_client"
23+
"event_engine_client,event_engine_listener"
2424
)
2525

2626
# Enter the gRPC repo root.
@@ -43,13 +43,13 @@ gcloud auth configure-docker
4343
# Connect to benchmarks-prod2 cluster.
4444
gcloud config set project grpc-testing
4545
gcloud container clusters get-credentials benchmarks-prod2 \
46-
--zone us-central1-b --project grpc-testing
46+
--zone us-central1-b --project grpc-testing
4747

4848
# Set up environment variables.
4949
LOAD_TEST_PREFIX="${KOKORO_BUILD_INITIATOR}"
5050
# BEGIN differentiate experimental configuration from master configuration.
5151
if [[ "${KOKORO_BUILD_INITIATOR%%-*}" == kokoro ]]; then
52-
LOAD_TEST_PREFIX=kokoro
52+
LOAD_TEST_PREFIX=kokoro
5353
fi
5454
# Use the "official" BQ tables so that the measurements will show up in the
5555
# "official" public dashboard.
@@ -64,9 +64,9 @@ ROOT_DIRECTORY_OF_DOCKERFILES="../test-infra/containers/pre_built_workers/"
6464
GRPC_COMMIT="$(git show --format="%H" --no-patch)"
6565
# Prebuilt workers for core languages are always built from grpc/grpc.
6666
if [[ "${KOKORO_GITHUB_COMMIT_URL%/*}" == "https://github.com/grpc/grpc/commit" ]]; then
67-
GRPC_CORE_COMMIT="${KOKORO_GIT_COMMIT}"
67+
GRPC_CORE_COMMIT="${KOKORO_GIT_COMMIT}"
6868
else
69-
GRPC_CORE_COMMIT="$(git ls-remote -h "https://github.com/${GRPC_CORE_REPO}.git" "${GRPC_CORE_GITREF}" | cut -f1)"
69+
GRPC_CORE_COMMIT="$(git ls-remote -h "https://github.com/${GRPC_CORE_REPO}.git" "${GRPC_CORE_GITREF}" | cut -f1)"
7070
fi
7171

7272
# Kokoro jobs run on dedicated pools.
@@ -89,62 +89,62 @@ declare -a loadtest_files=()
8989

9090
# Build test configurations.
9191
buildConfigs() {
92-
local -r pool="$1"
93-
local -r base_table="$2"
94-
local -r experiment="$3"
95-
shift 3
96-
# Multiple experiments are delimited by `__` (two underscores) in BigQuery.
97-
SANITIZED_EXPERIMENT="${experiment//,/__}"
98-
OUTFILE="loadtest_with_prebuilt_workers_${pool}_${SANITIZED_EXPERIMENT}.yaml"
99-
tools/run_tests/performance/loadtest_config.py "$@" \
100-
-t ./tools/run_tests/performance/templates/loadtest_template_prebuilt_cxx_experiments.yaml \
101-
-s driver_pool="${DRIVER_POOL}" -s driver_image= \
102-
-s client_pool="${pool}" -s server_pool="${pool}" \
103-
-s big_query_table="${base_table}_${SANITIZED_EXPERIMENT}" -s timeout_seconds=900 \
104-
-s prebuilt_image_prefix="${PREBUILT_IMAGE_PREFIX}" \
105-
-s prebuilt_image_tag="${UNIQUE_IDENTIFIER}" \
106-
-s grpc_experiment="${experiment}" \
107-
-a ci_buildNumber="${KOKORO_BUILD_NUMBER}" \
108-
-a ci_buildUrl="${CLOUD_LOGGING_URL}" \
109-
-a ci_jobName="${KOKORO_JOB_NAME}" \
110-
-a ci_gitCommit="${GRPC_COMMIT}" \
111-
-a ci_gitCommit_core="${GRPC_CORE_COMMIT}" \
112-
-a ci_gitActualCommit="${KOKORO_GIT_COMMIT}" \
113-
--prefix="${LOAD_TEST_PREFIX}" -u "${UNIQUE_IDENTIFIER}" -u "${pool}" \
114-
-a pool="${pool}" --category=dashboard \
115-
--allow_client_language=c++ --allow_server_language=c++ \
116-
--allow_server_language=node \
117-
-o "${OUTFILE}"
118-
119-
loadtest_files+=(-i "${OUTFILE}")
92+
local -r pool="$1"
93+
local -r base_table="$2"
94+
local -r experiment="$3"
95+
shift 3
96+
# Multiple experiments are delimited by `__` (two underscores) in BigQuery.
97+
SANITIZED_EXPERIMENT="${experiment//,/__}"
98+
OUTFILE="loadtest_with_prebuilt_workers_${pool}_${SANITIZED_EXPERIMENT}.yaml"
99+
tools/run_tests/performance/loadtest_config.py "$@" \
100+
-t ./tools/run_tests/performance/templates/loadtest_template_prebuilt_cxx_experiments.yaml \
101+
-s driver_pool="${DRIVER_POOL}" -s driver_image= \
102+
-s client_pool="${pool}" -s server_pool="${pool}" \
103+
-s big_query_table="${base_table}_${SANITIZED_EXPERIMENT}" -s timeout_seconds=900 \
104+
-s prebuilt_image_prefix="${PREBUILT_IMAGE_PREFIX}" \
105+
-s prebuilt_image_tag="${UNIQUE_IDENTIFIER}" \
106+
-s grpc_experiment="${experiment}" \
107+
-a ci_buildNumber="${KOKORO_BUILD_NUMBER}" \
108+
-a ci_buildUrl="${CLOUD_LOGGING_URL}" \
109+
-a ci_jobName="${KOKORO_JOB_NAME}" \
110+
-a ci_gitCommit="${GRPC_COMMIT}" \
111+
-a ci_gitCommit_core="${GRPC_CORE_COMMIT}" \
112+
-a ci_gitActualCommit="${KOKORO_GIT_COMMIT}" \
113+
--prefix="${LOAD_TEST_PREFIX}" -u "${UNIQUE_IDENTIFIER}" -u "${pool}" \
114+
-a pool="${pool}" --category=dashboard \
115+
--allow_client_language=c++ --allow_server_language=c++ \
116+
--allow_server_language=node \
117+
-o "${OUTFILE}"
118+
119+
loadtest_files+=(-i "${OUTFILE}")
120120
}
121121

122122
for experiment in "${GRPC_EXPERIMENTS[@]}"; do
123-
buildConfigs "${WORKER_POOL_8CORE}" "${BIGQUERY_TABLE_8CORE}" "${experiment}" -l c++
124-
buildConfigs "${WORKER_POOL_32CORE}" "${BIGQUERY_TABLE_32CORE}" "${experiment}" -l c++
123+
buildConfigs "${WORKER_POOL_8CORE}" "${BIGQUERY_TABLE_8CORE}" "${experiment}" -l c++
124+
buildConfigs "${WORKER_POOL_32CORE}" "${BIGQUERY_TABLE_32CORE}" "${experiment}" -l c++
125125
done
126126

127127
# Delete prebuilt images on exit.
128128
deleteImages() {
129-
echo "deleting images on exit"
130-
../test-infra/bin/delete_prebuilt_workers \
131-
-p "${PREBUILT_IMAGE_PREFIX}" \
132-
-t "${UNIQUE_IDENTIFIER}"
129+
echo "deleting images on exit"
130+
../test-infra/bin/delete_prebuilt_workers \
131+
-p "${PREBUILT_IMAGE_PREFIX}" \
132+
-t "${UNIQUE_IDENTIFIER}"
133133
}
134134
trap deleteImages EXIT
135135

136136
# Build and push prebuilt images for running tests.
137137
time ../test-infra/bin/prepare_prebuilt_workers \
138-
-l "cxx:${GRPC_CORE_REPO}:${GRPC_CORE_COMMIT}" \
139-
-p "${PREBUILT_IMAGE_PREFIX}" \
140-
-t "${UNIQUE_IDENTIFIER}" \
141-
-r "${ROOT_DIRECTORY_OF_DOCKERFILES}"
138+
-l "cxx:${GRPC_CORE_REPO}:${GRPC_CORE_COMMIT}" \
139+
-p "${PREBUILT_IMAGE_PREFIX}" \
140+
-t "${UNIQUE_IDENTIFIER}" \
141+
-r "${ROOT_DIRECTORY_OF_DOCKERFILES}"
142142

143143
# Run tests.
144144
../test-infra/bin/runner \
145-
${loadtest_files[@]} \
146-
-log-url-prefix "${LOG_URL_PREFIX}" \
147-
-polling-interval 5s \
148-
-delete-successful-tests \
149-
-c "${WORKER_POOL_8CORE}:2" -c "${WORKER_POOL_32CORE}:2" \
150-
-o "runner/sponge_log.xml"
145+
"${loadtest_files[@]}" \
146+
-log-url-prefix "${LOG_URL_PREFIX}" \
147+
-polling-interval 5s \
148+
-delete-successful-tests \
149+
-c "${WORKER_POOL_8CORE}:2" -c "${WORKER_POOL_32CORE}:2" \
150+
-o "runner/sponge_log.xml"

0 commit comments

Comments
 (0)