test some more update()/save-as() variants

Author: dwarring

coverage/PDF.rakucov

@@ -112,7 +112,7 @@ x         False;
   }
   #| perform an incremental save back to the opened input file, or write
   #| differences to the specified file
-* method update(IO::Handle :$diffs, |c) {
+* method update(IO::Handle :$diffs, |c) is hidden-from-backtrace {
 
 *     die "Newly encrypted PDF must be saved in full"
           if $!flush;
@@ -162,7 +162,7 @@ x             $in-place = True;
       }
   }
 
-* method !incremental-save(IO::Handle:D $fh, Hash $body, :$diffs, :$in-place) {
+* method !incremental-save(IO::Handle:D $fh, Hash $body, :$diffs, :$in-place) is hidden-from-backtrace {
       my constant Pad = "\n\n".encode('latin-1');
 
 ✱     my Hash $trailer = $body<trailer><dict>;
@@ -203,8 +203,8 @@ x             $in-place = True;
 *     PDF::IO::Writer.new: :$ast;
   }
 
-x multi method save-as(IO::Handle $ioh, |c) {
-x     self!ast-writer(|c).stream-cos: $ioh;
+* multi method save-as(IO::Handle $ioh, |c) is hidden-from-backtrace {
+*     self!ast-writer(|c).stream-cos: $ioh;
   }
 
 * multi method save-as(IO() $iop,

coverage/PDF/IO/Reader.rakucov

@@ -307,7 +307,7 @@ x                 die "unable to handle indirect object update of type: $_";
           # ensure stream is followed by an 'endstream' marker
 *         my Str \tail = $input.byte-str( $offset + $from + $length, $max-remaining-bytes - $length);
 
-*         if tail ~~ m{^<PDF::Grammar::COS::stream-tail>} {
+*         if tail ~~ m{^<PDF::Grammar::COS::stream-tail> 'endobj'} {
 *             warn X::PDF::BadIndirectObject.new(
                   :$obj-num, :$gen-num, :$offset,
 x                 :details("Ignoring {$/.from} bytes before 'endstream' marker")
@@ -316,7 +316,7 @@ x                 :details("Ignoring {$/.from} bytes before 'endstream' marker")
           else {
 *             die X::PDF::BadIndirectObject.new(
                   :$obj-num, :$gen-num, :$offset,
-                  :details("Unable to locate 'endstream' marker after consuming /Length $length bytes")
+                  :details("Unable to locate 'endstream' 'endobj' sequence after consuming /Length $length bytes")
                   );
           }
 

coverage/PDF/IO/Writer.rakucov

@@ -377,8 +377,8 @@ x             .rethrow();
 *     self.stream-body: $fh, $body, my @idx, :$write-xref;
   }
 
-x multi method stream-cos(IO::Handle:D $fh) {
-x     $.stream-cos($fh, $!ast<cos>);
+* multi method stream-cos(IO::Handle:D $fh) {
+*     $.stream-cos($fh, $!ast<cos>);
   }
 
 * multi method stream-body(IO::Handle:D $fh, @body, |c) {

coverage/X/PDF.rakucov

@@ -64,9 +64,9 @@ x     method message {"xref section size mismatch. Expected $!obj-count entries,
 
 * class X::PDF::BadIndirectObject::Parse is X::PDF::BadIndirectObject {
       has Str $.input is required;
-*     method message {
-*         $.details = "Unable to parse indirect object: " ~ $.input.&synopsis();
-*         nextsame;
+x     method message {
+x         $.details = "Unable to parse indirect object: " ~ $.input.&synopsis();
+x         nextsame;
       }
   }
 

lib/PDF.rakumod

@@ -112,7 +112,7 @@ method cb-finish {
 }
 #| perform an incremental save back to the opened input file, or write
 #| differences to the specified file
-method update(IO::Handle :$diffs, |c) {
+method update(IO::Handle :$diffs, |c) is hidden-from-backtrace {
 
     die "Newly encrypted PDF must be saved in full"
         if $!flush;
@@ -162,7 +162,7 @@ method update(IO::Handle :$diffs, |c) {
     }
 }
 
-method !incremental-save(IO::Handle:D $fh, Hash $body, :$diffs, :$in-place) {
+method !incremental-save(IO::Handle:D $fh, Hash $body, :$diffs, :$in-place) is hidden-from-backtrace {
     my constant Pad = "\n\n".encode('latin-1');
 
     my Hash $trailer = $body<trailer><dict>;
@@ -203,7 +203,7 @@ method !ast-writer(|c) {
     PDF::IO::Writer.new: :$ast;
 }
 
-multi method save-as(IO::Handle $ioh, |c) {
+multi method save-as(IO::Handle $ioh, |c) is hidden-from-backtrace {
     self!ast-writer(|c).stream-cos: $ioh;
 }
 

t/00-helloworld.t

@@ -1,6 +1,6 @@
 use v6;
 use Test;
-plan 11;
+plan 12;
 
 use PDF;
 use PDF::COS::Name;
@@ -50,4 +50,5 @@ ok PDF::Grammar::PDF.parse( $pdf.Str: :compat(v1.5) ), '$pdf.Str v1.5 serializat
 lives-ok {$pdf .= open: $pdf.Blob}, 'reserialize from Blob';
 is-deeply $pdf.Info.Author, $info.Author, 'Info intact';
 lives-ok {$pdf.Blob}, 'second reserialization';
+lives-ok {$pdf.save-as("tmp/helloworld.pdf".IO.open(:w, :bin))}, 'save-as pdf IO::Handle';
 done-testing;

t/helloworld.pdf

@@ -0,0 +1,15 @@
+%FDF-1.2
+%���
+1 0 obj
+<<
+  /FDF <<
+    /F (Document.pdf)
+    /Fields [ << /T (Street) /V (345 Park Ave.) >> << /T (City) /V (San Jose) >> ]
+    /ID [ <7a0631678ed475f0898815f0a818cfa1> <bef7724317b311718e8675b677ef9b4e> ]
+  >>
+>>
+endobj
+
+trailer
+<< /Root 1 0 R >>
+%%EOF