Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling go metric collection #2

Closed
martinvelez opened this issue Apr 3, 2019 · 2 comments
Closed

Disabling go metric collection #2

martinvelez opened this issue Apr 3, 2019 · 2 comments
Labels
enhancement New feature or request priority:low

Comments

@martinvelez
Copy link

martinvelez commented Apr 3, 2019

Is there a way to not collect certain metrics, like go metrics?

# HELP go_gc_duration_seconds A summary of the GC invocation durations.
# TYPE go_gc_duration_seconds summary
go_gc_duration_seconds{quantile="0"} 0
go_gc_duration_seconds{quantile="0.25"} 0
go_gc_duration_seconds{quantile="0.5"} 0
go_gc_duration_seconds{quantile="0.75"} 0
go_gc_duration_seconds{quantile="1"} 0
...

I think this is possible in Node Exporter (see prometheus/node_exporter#1148).

@pdf pdf added enhancement New feature or request priority:low labels Apr 3, 2019
@pdf
Copy link
Owner

pdf commented Apr 3, 2019

The Go metrics are included by default on all exporters by the upstream promhttp package, which is why you'll see these metrics on nearly all the third-party collectors. That node_exporter PR is a significant refactor, so I'll need to dig into promhttp to work out how to avoid exposing them.

This does not seem like a high priority change, so it may take me a little time before I can address it, happy to review a PR though.

@pdf
Copy link
Owner

pdf commented Jun 21, 2021

I've reported this upstream, since it seems to me that incorporating this behaviour there would be a win for all exporters, we'll see what the concensus is:

prometheus/exporter-toolkit#119

@pdf pdf closed this as completed in 1ca8717 Sep 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority:low
Projects
None yet
Development

No branches or pull requests

2 participants