gsr reservation widget refactored in retrofit2 #645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Divak2004
requested review from
meiron03,
baronhsieh2005,
trinif,
vavali08 and
joemacd
|
Actually test to see if the widget removes reservations after they are over. Check gsr reservation implementation to see how they implement removing reservations when over. |
baronhsieh2005
approved these changes
Jul 6, 2025
| @@ -125,6 +127,15 @@ class MainActivity : AppCompatActivity() { | |||
| if (diningWidgetBroadCast != -1) { | |||
| setTab(DINING_ID) | |||
| } | |||
|
|
|||
| var gsrReservationWidgetBroadCast = 0 | |||
| if (intent != null) { | |||
There was a problem hiding this comment.
Could use the scope function let here (a nitpick tho)
| } | ||
| } | ||
|
|
||
| override fun onDeleted( |
There was a problem hiding this comment.
Might have to consider canceling/stopping the alarmmanager here as well (since this is essentially an ondestroy for app widget provider). I might have to add this for my own dining widget implementation as well
| } | ||
| } | ||
|
|
||
| companion object { |
There was a problem hiding this comment.
Hopefully after Aaron's Network PR we can separate this and make this more modular with DI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.