Misplaced parameter in `cms_list_native_files`?

[raymondben]

cms_download_native uses aws.s3::get_bucket_df to list the contents of the bucket. On line https://github.com/pepijn-devries/CopernicusMarine/blob/master/R/cms_download_native.R#L103 the call to get_bucket_df includes an un-named path parameter:

    aws.s3::get_bucket_df(
      path,
      region = "",
      bucket = bucket,
      ...

This unnamed parameter gets used as the delimiter parameter by get_bucket_df (because that's the first parameter that doesn't match any of the named parameters being passed). Is this intentional? It doesn't seem right to me but I could easily be wrong. If it is intended, perhaps name that parameter to avoid ambiguity. (I don't think it's causing any problems though, at least in the examples I am working with.)

As a side note, cms_list_native_files currently fails to page through results correctly in some cases. But it seems to be an issue in aws.s3::get_bucket and should be resolved by cloudyr/aws.s3#414.

[pepijn-devries]

Hi @raymondben ,

Thanks for reporting. I will name the argument, to avoid any ambiguity. Will do so next time I get around working on this package. I'm currently working on a blosc-package to support subsetting

[pepijn-devries]

It seems that the path-argument was not needed at all and should be ignored. I have removed it...