EVEREST-1719 - Add test for restore to new cluster from scheduled backup #1229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@fabio-silva @dianabirs @tplavcic Can you please review this PR. Thanks |
fabio-silva
suggested changes
Mar 20, 2025
dianabirs
reviewed
Mar 20, 2025
tplavcic
changed the title
tplavcic
suggested changes
Mar 21, 2025
Contributor
Author
|
Thanks for the feedback! I'm currently working on another high-priority task and plan to get back to this PR later next week. |
- Replace manual loop with moveForward() and use test.step() blocks for clarity - Dynamically inject clusterName and restoredClusterName into test titles - Improve backup schedule creation and validation flow for primary and restored clusters - Add waitForDbListLoad() for consistent DB list readiness before deletion - Refactor findRowAndClickActions to use new getClusterRow() for more precise row targeting - Clean up and unify row selectors across table.ts utility functions
dianabirs
approved these changes
Apr 24, 2025
fabio-silva
approved these changes
Apr 24, 2025
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
tplavcic
suggested changes
Apr 25, 2025
tplavcic
changed the title
tplavcic
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated table.ts to fix row selection issues and created tests for restore to a new cluster. Some code is commented out as it requires additional fixes before merging.
Jira Ticket: Everest-1719