K8SPXC-1494: add .spec.tls.certValidityDuration field
#2127
+116
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egegunes
reviewed
Nov 6, 2025
pkg/controller/pxc/tls.go
Outdated
| Group: issuerGroup, | ||
| }, | ||
| Duration: &metav1.Duration{Duration: pxctls.DefaultValidity}, | ||
| Duration: duration, |
Contributor
There was a problem hiding this comment.
so when i set validity duration all certs will be valid for this duration, including CA. i wonder if this will make rotation harder when these certs are expired. in PSMDB operator, we don't use this field for CA cert and hardcode 365 days for its validity duration (i don't think that approach is correct either bc what happens if user specifies 366 days for cert validity?). maybe we need to have a separate field for CA validity duration?
@hors wdyt?
Collaborator
There was a problem hiding this comment.
I am ok to add a separate field for CA validity duration
pooknull
requested review from
eleo007,
gkech,
jvpasinatto,
nmarukovich and
valmiranogueira
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://perconadev.atlassian.net/browse/K8SPXC-1494
DESCRIPTION
This PR adds a
.spec.tls.certValidityDurationand.spec.tls.caValidityDurationfields to thecr.yaml. These fields control the validity period of the TLS certificates generated by the operatorCHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
compare/*-oc.yml)?Config/Logging/Testability