Skip to content

Conversation

@dAdAbird
Copy link
Member

A new GUC option is applied to all newly created keys - both principal and internal.
We had to change the _keys file format to accommodate 32-byte internal keys. So the keys file migration routine was added at server start.

Adds a respective GUC and enables TDE AES lib to handle 128 and 256-bit keys.
Also adds the support for 256 bit encryption of primary keys
It adds `pg_tde/keys_version`, which contains the latest magic number
(version) of the wal and smgr keys. If those versions don't match the
current ones at the server start, it will rewrite _keys to the new
format if needed and update keys_version.
If the start crashed along the way updating _keys, it will retry again
on the next start since keys_version wasn't updated.
This is a temporary fix. Tools will be addressed properly in the following PR
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 37.11790% with 144 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.08%. Comparing base (44684d3) to head (226259f).
⚠️ Report is 1 commits behind head on main.

❌ Your project status has failed because the head coverage (59.08%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #465      +/-   ##
==========================================
- Coverage   59.69%   59.08%   -0.62%     
==========================================
  Files          67       67              
  Lines       10471    10641     +170     
  Branches     1813     1838      +25     
==========================================
+ Hits         6251     6287      +36     
- Misses       3524     3653     +129     
- Partials      696      701       +5     
Components Coverage Δ
access 73.06% <22.22%> (-11.83%) ⬇️
catalog 87.93% <100.00%> (ø)
common 77.77% <ø> (ø)
encryption 72.64% <80.95%> (+1.07%) ⬆️
keyring 73.54% <100.00%> (ø)
src 90.90% <61.11%> (-3.30%) ⬇️
smgr 94.06% <100.00%> (ø)
transam ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants