PMM-12478 external exporter status #4726
Draft
+1,436
−252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## v3 #4726 +/- ##
==========================================
- Coverage 45.75% 45.62% -0.13%
==========================================
Files 364 365 +1
Lines 37755 37848 +93
==========================================
- Hits 17275 17269 -6
- Misses 18823 18920 +97
- Partials 1657 1659 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ademidoff
reviewed
Nov 6, 2025
| map<string, string> custom_labels = 7; | ||
| // Group name of external service. | ||
| string group = 8; | ||
| // Access address (DNS name or IP). |
Member
There was a problem hiding this comment.
Suggested change
| // Access address (DNS name or IP). | |
| // Service address (DNS name or IP). |
| string group = 8; | ||
| // Access address (DNS name or IP). | ||
| string address = 9; | ||
| // Access port. |
Member
There was a problem hiding this comment.
Suggested change
| // Access port. | |
| // Service port. |
|
|
||
| s.l.Debugf("Updating status for %d external exporters.", len(statusMap)) | ||
|
|
||
| err = s.db.InTransaction(func(tx *reform.TX) error { |
Member
There was a problem hiding this comment.
Better use .InTransactionContext wherever the context is available.
| status = inventoryv1.AgentStatus_AGENT_STATUS_UNKNOWN | ||
| } | ||
|
|
||
| err = s.db.InTransaction(func(tx *reform.TX) error { |
managed/services/inventory/agents.go
Outdated
| // This allows VictoriaMetrics to scrape the exporter and generate 'up' metric | ||
| agentID := agent.AgentId | ||
| go func() { | ||
| time.Sleep(15 * time.Second) |
Member
There was a problem hiding this comment.
Should this be a magic number or a named constant?
ademidoff
reviewed
Nov 6, 2025
managed/services/inventory/agents.go
Outdated
| // This allows VictoriaMetrics to scrape the exporter and generate 'up' metric | ||
| agentID := agent.AgentId | ||
| go func() { | ||
| time.Sleep(15 * time.Second) |
Member
There was a problem hiding this comment.
IMO everything should be context-bound and the sleep itself should be cancellable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-12478
Link to the Feature Build: SUBMODULES-0
If this PR adds, removes or alters one or more API endpoints, please review and add or update the relevant API documentation as well:
If this PR is related to some other PRs in this or other repositories, please provide links to those PRs: