Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestRunner ignores the TestPackage.OutputTargets list #350

Open
taaaki opened this issue Jul 14, 2020 · 0 comments
Open

TestRunner ignores the TestPackage.OutputTargets list #350

taaaki opened this issue Jul 14, 2020 · 0 comments

Comments

@taaaki
Copy link
Contributor

taaaki commented Jul 14, 2020

When working with a TestPackage, it is possible to add a custom IBenchmarkOutput implementation using the TestPackage.AddOutput function. However, any such custom IBenchmarkOutput implementations are effectively ignored by the TestRunner as it does not include the TestPackage.OutputTargets when constructing the CompositeBenchmarkOutput that is then used by the runner. Based on the summary comment for OutputTargets, this appears to be an accidental omission rather than a design choice.

There is a workaround whereby the TestRunner can be inherited from and the CreateOutput function overridden to produce the CompositeBenchmarkOutput that includes the additional output targets. But this doesn't appear to be the intended approach as far as I can tell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant