Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Mesh filename handling #443

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

TJMolnar
Copy link

Many URDF files make use of the file:// prefix when specifying filenames for loading geometry or collision meshes. For an example, refer to this line in the xacro for the Kinova Gen3:

<mesh filename="file://$(find kortex_description)/arms/gen3/${dof}dof/meshes/base_link.dae" />

This PR Adds an explicit check for the "file://" prefix in roboticstoolbox/tools/urdf/urdf.py, alongside the existing check for "package://", to handle such filenames appropriately.

@petercorke petercorke changed the base branch from master to future July 29, 2024 04:11
@petercorke petercorke merged commit 4f0d3ff into petercorke:future Jul 29, 2024
@petercorke
Copy link
Owner

thanks for this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incomplete handling of mesh filenames in URDF parsing
2 participants