Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in signature serialize/deserialize #295

Open
krisk0 opened this issue Dec 12, 2023 · 2 comments
Open

Bug in signature serialize/deserialize #295

krisk0 opened this issue Dec 12, 2023 · 2 comments

Comments

@krisk0
Copy link

krisk0 commented Dec 12, 2023

DERSignature.stream_serialize puts byte 0x30 between r and s. But .stream_deserialize expects 0x02 there.

I think this is a bug in either DERSignature.stream_serialize or DERSignature.stream_deserialize.
@petertodd
Copy link
Owner

Adding this for my own notes when I get some time to look into this: https://b10c.me/blog/006-evolution-of-the-bitcoin-signature-length/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@petertodd @krisk0 and others