Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sendmany.py might try to RBF someone else's transaction #6

Open
sdaftuar opened this issue Jan 5, 2016 · 1 comment
Open

sendmany.py might try to RBF someone else's transaction #6

sdaftuar opened this issue Jan 5, 2016 · 1 comment

Comments

@sdaftuar
Copy link

sdaftuar commented Jan 5, 2016

I believe sendmany.py will do the wrong thing in the case where it tries to find a transaction to replace from your node.

Right now the code calls listunspent(0,0), but doesn't do additional filtering to ensure that the transaction you're trying to replace is one that you can actually sign for. In particular, if you have an unconfirmed transaction which someone else created that tries to pay you, you might try to RBF that, which is likely to fail...

@petertodd
Copy link
Owner

Ha, good point! IIRC I do check that a tx is RBF-able first, so someone would have to send you an opt-in RBF tx... which is likely to happen in testing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants