Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ‹dia-controller› to allow opt-in/out of child controllers #12

Open
1 of 3 tasks
olange opened this issue Mar 22, 2019 · 0 comments
Open
1 of 3 tasks
Assignees

Comments

@olange
Copy link
Collaborator

olange commented Mar 22, 2019

Keyboard and remote Firebase controllers are now built-in the Shadow DOM of the ‹dia-controller›. The user cannot opt-out from Firebase remote controller, for instance.

Refactor those elements and their classes, to allow the user to control which controller she·he wants to enable in his slideshow. They should not come automatically enabled, when installing the packages.

Actions

  • Clarify communication between DiaKeyboardController and DiaController DONE 22.03 actions via custom events now, instead of method calls
  • Y TODO
  • Z TODO

See also

@olange olange self-assigned this Mar 22, 2019
olange added a commit that referenced this issue Mar 22, 2019
…m events (#5 and #12)

… instead of method calls on parent ‹dia-controller› element, which complected both together
olange added a commit that referenced this issue Mar 26, 2019
…#12)

and refactors the preceding-/following-sibling selection logic using an XPath expression
olange added a commit that referenced this issue May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant