-
Notifications
You must be signed in to change notification settings - Fork 49
feat: implement comprehensive alarm logic system with Nelson Rules and advanced detection methods #75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
xzxjesse
wants to merge
22
commits into
petrobras:main
Choose a base branch
from
xzxjesse:issue-39-alarm-logics
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…modelos com Y e métricas
…a modelos sem Y e com X_pred_to_plot
…para modelos sem Y e sem X_pred_to_plot
…ela apenas com tempos
…eríodo de falha definido
…ra falha apenas com início definido
…ara tabela apenas com predições
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements a comprehensive alarm logic system for BibMon, including all 8 classical Nelson Rules for statistical process control and advanced anomaly detection methods.
Implemented Features
Nelson Rules (1-8)
Advanced Detection Methods
Technical Implementation
_alarms.pymoduleBenefits
Testing
Impact
This implementation resolves issue #39, significantly expanding BibMon's anomaly detection capabilities, making it more suitable for monitoring complex industrial processes.
Modified Files
bibmon/_alarms.py: Implementation of detection functionstest/test_tools.py: Unit tests for all functionalitiesDevelopment Methodology
Development following TDD (Test-Driven Development), ensuring code quality and reliability of the implemented features.
Code Quality
Compatibility