Skip to content

Conversation

@jguarato
Copy link
Collaborator

@jguarato jguarato commented Oct 4, 2024

For some specific bearing classes (e.g. BallBearingElement, RollerBearingElement, BearingFluidFlow, CylindricalBearing), the save to .toml file method was unable to save the names of these classes due to inconsistencies between their initialization arguments and the class attributes. These issues have now been fixed and the names of the respective classes are now effectively stored in the output file to be later loaded as defined by the user.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.42%. Comparing base (f6ca34f) to head (36cab38).
Report is 13 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1118      +/-   ##
==========================================
- Coverage   84.52%   84.42%   -0.10%     
==========================================
  Files          35       35              
  Lines        7966     8002      +36     
==========================================
+ Hits         6733     6756      +23     
- Misses       1233     1246      +13     
Files with missing lines Coverage Δ
ross/bearing_seal_element.py 92.90% <100.00%> (+0.30%) ⬆️
ross/element.py 87.03% <100.00%> (+0.24%) ⬆️
ross/rotor_assembly.py 93.87% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e5c2cd...36cab38. Read the comment docs.

@raphaeltimbo raphaeltimbo merged commit 92b522f into petrobras:main Oct 10, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants