Class honeycomb seal (hcomb) #1207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1207 +/- ##
==========================================
- Coverage 79.11% 77.18% -1.93%
==========================================
Files 40 41 +1
Lines 11058 11430 +372
==========================================
+ Hits 8748 8822 +74
- Misses 2310 2608 +298
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
jguarato
reviewed
Sep 29, 2025
jguarato
approved these changes
Sep 29, 2025
Enable gas_composition parameter to work seamlessly with or without REFPROP by: - Handling HEOS convergence issues when fitting Sutherland coefficients - Making ccp a required dependency (not optional) to leverage auto-backend selection - Adding comprehensive test coverage for both REFPROP and HEOS backends This ensures users without REFPROP license can still use gas_composition parameter via CoolProp's HEOS backend, while maintaining full backward compatibility.
Similar to test_hcomb.py, add 13 comprehensive tests covering: - Manual parameter tests (always run) - gas_composition tests (both REFPROP and HEOS) - REFPROP vs HEOS comparison tests (REFPROP-only) - Edge cases and error handling - Multiple frequencies support - Coefficient symmetry validation - Backward compatibility Tests verify that gas_composition parameter works seamlessly with or without REFPROP, with differences <0.05% between backends.
Rename class, files, and all references from hcomb/honeycomb to holepattern: - Rename hcomb_seal.py → holepattern_seal.py - Rename test_hcomb.py → test_holepattern.py - Rename HoneycombSeal → HolePatternSeal - Update all imports in __init__.py and rotor_assembly.py - Update all variable names and docstrings - All tests passing (13 passed in 5.40s)
Replace manual thermodynamic parameters (b_suther, s_suther, molar, gamma, r, tz, muz) with gas_composition in docstring examples for both HolePatternSeal and LabyrinthSeal. This promotes the recommended approach and demonstrates the simpler API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a class for simulating hcomb seals, along with @vitorp0604