Skip to content

Conversation

@murilloabs
Copy link
Contributor

Implementation of the new Gear Mesh Stiffness methodology, which includes both spur and helical gears. Automatically calculating the stiffness value used.

@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 97.63314% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.96%. Comparing base (07a5a63) to head (1dcd86a).
⚠️ Report is 245 commits behind head on main.

Files with missing lines Patch % Lines
ross/multi_rotor.py 98.13% 3 Missing ⚠️
ross/gear_element.py 87.50% 1 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1209      +/-   ##
==========================================
- Coverage   82.91%   74.96%   -7.96%     
==========================================
  Files          39       38       -1     
  Lines        8247     8858     +611     
==========================================
- Hits         6838     6640     -198     
- Misses       1409     2218     +809     
Files with missing lines Coverage Δ
ross/gear_element.py 92.00% <87.50%> (-0.86%) ⬇️
ross/multi_rotor.py 93.63% <98.13%> (+5.00%) ⬆️

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67503f3...1dcd86a. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@raphaeltimbo
Copy link
Collaborator

Hi, @murilloabs ! Thanks for the PR.

I have only some minor comments.

First, could you please add some tests to check the GearElement class?
You could create a test_gear_element.py to the test folder and add some tests there. These tests could be based on one of the examples available in the tutorial.

Regarding the tutorial, here you added a command to add a local path to sys:
image

If you could please remove this since it is related to your local environment.
A better approach would be to install ross locally going to your ross folder and using pip install -e .
This will add the ross folder to your path and you won't need to use the sys.append in your scripts.

@murilloabs
Copy link
Contributor Author

I have noticed a minimal mistake at the contact ratio formulation. I have swapped radius with diameter of the gear. I have corrected this mistake and the pytest was not updated. Now, I already update the pytest and I made the test files: test_gear_element.py and test_multi_rotor.py.

@raphaeltimbo raphaeltimbo merged commit 39181cc into petrobras:main Sep 18, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants