-
Notifications
You must be signed in to change notification settings - Fork 126
New methodology for gear mesh stiffness #1209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1209 +/- ##
==========================================
- Coverage 82.91% 74.96% -7.96%
==========================================
Files 39 38 -1
Lines 8247 8858 +611
==========================================
- Hits 6838 6640 -198
- Misses 1409 2218 +809
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
Hi, @murilloabs ! Thanks for the PR. I have only some minor comments. First, could you please add some tests to check the GearElement class? Regarding the tutorial, here you added a command to add a local path to sys: If you could please remove this since it is related to your local environment. |
|
I have noticed a minimal mistake at the contact ratio formulation. I have swapped radius with diameter of the gear. I have corrected this mistake and the pytest was not updated. Now, I already update the pytest and I made the test files: test_gear_element.py and test_multi_rotor.py. |

Implementation of the new Gear Mesh Stiffness methodology, which includes both spur and helical gears. Automatically calculating the stiffness value used.