-
Notifications
You must be signed in to change notification settings - Fork 126
Model Reduction #1212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Model Reduction #1212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace mutable default arguments ([], ["x", "y"]) with None in Guyan.__init__ - Replace mutable default arguments in Guyan._separate_dofs - Add proper None checks and initialization for default values - Fix docstring in Guyan.revert_vector (was incorrectly stating "complete to reduced") This eliminates the mutable default argument anti-pattern which could cause subtle bugs where default values persist across multiple function calls. All tests pass: - 26 doctests in model_reduction.py - 3 integration tests in test_transient_newmark.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new
ModelReductionclass that provides a modular and extensible framework for applying different model reduction techniques. Currently, two reduction strategies are implemented:The
ModelReductionclass is now integrated into theRotor.run_time_response()method, enabling model reduction during transient simulations.Example Usage
Guyan Reduction:
PseudoModal:
For the compressor model available as an example in ROSS, a good approximation with the reduction model was obtained and a computational time reduction of ~70%:

By extracting the maximum response over a range of speeds—using the reduced model of another system mounted with ROSS —it was possible to obtain the following comparison:
