Skip to content

Conversation

@Raimundovpn
Copy link
Collaborator

This pull request introduces a new function for calculating the unbalance response. This was developed to address inconsistencies and divergences observed between the results generated by the existing run_unbalance_response function and those from other established tools.

These discrepancies have been documented in the following issues:

Divergence when using the run_unbalance_response function (#1208)

Error in determining the unbalance response at the bearing supports position (#1214)

Inaccurate Unbalance Response for rotors with cross-coupled journal bearings (#1153)

The new implementation demonstrates a clear convergence with results from technical reports and other software, ensuring more reliable and accurate simulations.

@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 71.73913% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.84%. Comparing base (209611a) to head (af18f79).
⚠️ Report is 206 commits behind head on main.

Files with missing lines Patch % Lines
ross/results.py 61.29% 12 Missing ⚠️
ross/rotor_assembly.py 93.33% 1 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1216      +/-   ##
==========================================
+ Coverage   72.01%   74.84%   +2.83%     
==========================================
  Files          39       38       -1     
  Lines        9072     8854     -218     
==========================================
+ Hits         6533     6627      +94     
+ Misses       2539     2227     -312     
Files with missing lines Coverage Δ
ross/rotor_assembly.py 92.76% <93.33%> (-0.08%) ⬇️
ross/results.py 74.10% <61.29%> (-0.43%) ⬇️

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39181cc...af18f79. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Raimundovpn Raimundovpn marked this pull request as ready for review October 1, 2025 17:15
@raphaeltimbo raphaeltimbo merged commit 92764e4 into petrobras:main Oct 3, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants