-
Notifications
You must be signed in to change notification settings - Fork 126
Frf #1216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frf #1216
Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1216 +/- ##
==========================================
+ Coverage 72.01% 74.84% +2.83%
==========================================
Files 39 38 -1
Lines 9072 8854 -218
==========================================
+ Hits 6533 6627 +94
+ Misses 2539 2227 -312
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
… and minor axis and angle
This pull request introduces a new function for calculating the unbalance response. This was developed to address inconsistencies and divergences observed between the results generated by the existing run_unbalance_response function and those from other established tools.
These discrepancies have been documented in the following issues:
Divergence when using the run_unbalance_response function (#1208)
Error in determining the unbalance response at the bearing supports position (#1214)
Inaccurate Unbalance Response for rotors with cross-coupled journal bearings (#1153)
The new implementation demonstrates a clear convergence with results from technical reports and other software, ensuring more reliable and accurate simulations.