Add hover functionality for bearing and seal elements #1229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement interactive hover information for bearing and seal elements in rotor plots, similar to existing shaft element hover functionality. - Add _hover_info() method to BearingElement base class - Add invisible hover markers at bearing centers in _patch() method - Display frequency-dependent coefficients at first and last frequencies - Show frequency/speed values in RPM for better readability - Scale marker size proportionally to bearing icon height - Include customized hover info for each bearing type: * SealElement: shows cross-coupled coefficients and seal leakage * BallBearingElement: shows geometric parameters (balls, diameter, etc.) * MagneticBearingElement: shows electromagnetic and PID parameters * CylindricalBearing: shows fluid film properties and eccentricity The hover markers are invisible (opacity=0) but fully interactive, allowing users to view detailed bearing information without visual clutter. Marker size automatically scales with the bearing's scale_factor to maintain proportional sizing across different bearing types.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1229 +/- ##
==========================================
- Coverage 83.25% 82.99% -0.26%
==========================================
Files 42 42
Lines 12120 12188 +68
==========================================
+ Hits 10090 10116 +26
- Misses 2030 2072 +42
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds interactive hover information to bearing and seal elements in rotor plots, similar to the existing shaft element hover functionality.
Features
Example
Hovering over a seal now displays: tag, node, frequency range (RPM), stiffness coefficients (Kxx, Kyy, Kxy, Kyx), damping coefficients (Cxx, Cyy, Cxy, Cyx), and seal leakage.