Root reqs that specify prereleases imply --pre. (#3004)

Fixes #3003

---------

Co-authored-by: Christoph Pröschel <[email protected]>

Author: jsirois

CHANGES.md

@@ -1,5 +1,12 @@
 # Release Notes
 
+## 2.69.1
+
+This release fixes `--venv-repository` handling of top-level requirements that specify pre-releases.
+Such resolves now imply `--pre`.
+
+* Root reqs that specify prereleases imply `--pre`. (#3004)
+
 ## 2.69.0
 
 This release adds a `pexec` console script as an alias for `pex3 run`.

pex/resolve/venv_resolver.py

@@ -504,10 +504,15 @@ def _resolve_from_venv(
         )
         local_project_requirements = OrderedSet()  # type: OrderedSet[LocalProjectRequirement]
         root_requirements = OrderedSet()  # type: OrderedSet[Requirement]
+        root_requirements_has_prereleases = False
         for parsed_requirement in parsed_requirements:
             if isinstance(parsed_requirement, LocalProjectRequirement):
                 local_project_requirements.add(parsed_requirement)
             else:
+                root_requirements_has_prereleases = (
+                    root_requirements_has_prereleases
+                    or parsed_requirement.requirement.specifier.prereleases
+                )
                 root_requirements.add(parsed_requirement.requirement)
                 direct_requirements_by_project_name[
                     parsed_requirement.requirement.project_name
@@ -537,7 +542,9 @@ def _resolve_from_venv(
             requirements=root_requirements,
             constraints_by_project_name=constraints_by_project_name,
             dependency_configuration=dependency_configuration,
-            allow_prereleases=pip_configuration.allow_prereleases,
+            allow_prereleases=(
+                root_requirements_has_prereleases or pip_configuration.allow_prereleases
+            ),
             compile=compile,
             ignore_errors=ignore_errors,
             result_type=result_type,

pex/version.py

@@ -1,4 +1,4 @@
 # Copyright 2015 Pex project contributors.
 # Licensed under the Apache License, Version 2.0 (see LICENSE).
 
-__version__ = "2.69.0"
+__version__ = "2.69.1"

tests/integration/test_issue_3003.py

@@ -0,0 +1,156 @@
+# Copyright 2025 Pex project contributors.
+# Licensed under the Apache License, Version 2.0 (see LICENSE).
+
+from __future__ import absolute_import
+
+import os.path
+import re
+import subprocess
+from textwrap import dedent
+
+import pytest
+
+from pex.common import safe_open, touch
+from pex.compatibility import commonpath
+from pex.interpreter import PythonInterpreter
+from pex.venv.virtualenv import Virtualenv
+from testing import run_pex_command
+from testing.pytest_utils.tmp import Tempdir
+
+
+@pytest.fixture
+def project_dir(tmpdir):
+    # type: (Tempdir) -> str
+
+    project_dir = tmpdir.join("project")
+    with safe_open(os.path.join(project_dir, "pyproject.toml"), "w") as fp:
+        fp.write(
+            dedent(
+                """\
+                [build-system]
+                requires = ["uv_build>=0.9,<0.10.0"]
+                build-backend = "uv_build"
+
+                [project]
+                name = "project"
+                version = "0.42.0"
+                description = "Repro of issue 3003"
+                requires-python = "==3.10.*"
+                dependencies = [
+                    "opentelemetry-semantic-conventions==0.59b0",
+                ]
+                """
+            )
+        )
+    touch(os.path.join(project_dir, "src", "project", "__init__.py"))
+    return project_dir
+
+
+@pytest.fixture
+def project_venv(project_dir):
+    # type: (str) -> Virtualenv
+
+    subprocess.check_call(args=["uv", "sync"], cwd=project_dir)
+    return Virtualenv(os.path.join(project_dir, ".venv"))
+
+
+def assert_opentelemetry_semconv(
+    python,  # type: PythonInterpreter
+    pex_root,  # type: str
+    pex,  # type: str
+):
+    # type: (...) -> None
+
+    output = (
+        subprocess.check_output(
+            args=[
+                python.binary,
+                pex,
+                "-c",
+                "from opentelemetry import semconv; print(semconv.__file__)",
+            ]
+        )
+        .decode("utf-8")
+        .strip()
+    )
+
+    assert pex_root == commonpath((pex_root, output))
+
+
+def test_edge_case_semver_version_satisfied(
+    tmpdir,  # type: Tempdir
+    project_dir,  # type: str
+    project_venv,  # type: Virtualenv
+    py310,  # type: PythonInterpreter
+):
+    # type: (...) -> None
+
+    pex_root = tmpdir.join("pex-root")
+    pex = tmpdir.join("project.pex")
+    run_pex_command(
+        args=[
+            "--pex-root",
+            pex_root,
+            "--runtime-pex-root",
+            pex_root,
+            "--pip-version",
+            "latest-compatible",
+            "--venv-repository",
+            project_venv.venv_dir,
+            "project",
+            "-o",
+            pex,
+            "--no-compress",
+        ],
+        python=project_venv.interpreter.binary,
+    ).assert_failure(
+        expected_error_re=r".*^{error_msg}$".format(
+            error_msg=re.escape(
+                "Resolve from venv at {venv_dir} failed: The virtual environment has "
+                "opentelemetry-semantic-conventions 0.59b0 installed but it does not meet top "
+                "level requirement project -> opentelemetry-semantic-conventions==0.59b0.".format(
+                    venv_dir=project_venv.venv_dir
+                )
+            ),
+        ),
+        re_flags=re.DOTALL | re.MULTILINE,
+    )
+
+    run_pex_command(
+        args=[
+            "--pex-root",
+            pex_root,
+            "--runtime-pex-root",
+            pex_root,
+            "--pip-version",
+            "latest-compatible",
+            "--venv-repository",
+            project_venv.venv_dir,
+            "project",
+            "-o",
+            pex,
+            "--no-compress",
+            "--pre",
+        ],
+        python=project_venv.interpreter.binary,
+    ).assert_success()
+    assert_opentelemetry_semconv(python=py310, pex_root=pex_root, pex=pex)
+
+    run_pex_command(
+        args=[
+            "--pex-root",
+            pex_root,
+            "--runtime-pex-root",
+            pex_root,
+            "--pip-version",
+            "latest-compatible",
+            "--venv-repository",
+            project_venv.venv_dir,
+            "opentelemetry-semantic-conventions==0.59b0",
+            "-o",
+            pex,
+            "--no-compress",
+        ],
+        python=project_venv.interpreter.binary,
+    ).assert_success()
+    assert_opentelemetry_semconv(python=py310, pex_root=pex_root, pex=pex)