Fix sdist tar extraction filtering for old Pythons. (#2992)

Fixes #2991

Author: jsirois

CHANGES.md

@@ -1,5 +1,11 @@
 # Release Notes
 
+## 2.68.1
+
+This release fixes a regression extracting sdists on some Pythons older than 3.12.
+
+* Fix sdist tar extraction filtering for old Pythons. (#2992)
+
 ## 2.68.0
 
 This release adds support for `--project` pointing to local project sdist or wheel paths in addition

pex/sdist.py

@@ -67,6 +67,7 @@ def _get_filtered_attrs(
     # + `os.path.realpath` -> `_realpath` to deal with `strict` parameter.
     # + `os.path.commonpath` -> `pex.compatibility.commonpath`
     # + `mode = None` guarded by `sys.version_info[:2] >= (3, 12)` with commentary.
+    # + `{uid,gid,uname,gname} = None` guarded by `sys.version_info[:2] >= (3, 12)` with commentary.
 
     new_attrs = {}  # type: Dict[str, Any]
     name = member.name
@@ -113,15 +114,20 @@ def _get_filtered_attrs(
         if mode != member.mode:
             new_attrs["mode"] = mode
     if for_data:
-        # Ignore ownership for 'data'
-        if member.uid is not None:
-            new_attrs["uid"] = None
-        if member.gid is not None:
-            new_attrs["gid"] = None
-        if member.uname is not None:
-            new_attrs["uname"] = None
-        if member.gname is not None:
-            new_attrs["gname"] = None
+        if sys.version_info[:2] >= (3, 12):
+            # Ignore ownership for 'data'
+            if member.uid is not None:
+                new_attrs["uid"] = None
+            if member.gid is not None:
+                new_attrs["gid"] = None
+            if member.uname is not None:
+                new_attrs["uname"] = None
+            if member.gname is not None:
+                new_attrs["gname"] = None
+        else:
+            # Retain uid/gid/uname/gname since older Pythons do not support None.
+            pass
+
         # Check link destination for 'data'
         if member.islnk() or member.issym():
             if os.path.isabs(member.linkname):

pex/version.py

@@ -1,4 +1,4 @@
 # Copyright 2015 Pex project contributors.
 # Licensed under the Apache License, Version 2.0 (see LICENSE).
 
-__version__ = "2.68.0"
+__version__ = "2.68.1"

tests/integration/test_issue_2991.py

@@ -0,0 +1,37 @@
+# Copyright 2025 Pex project contributors.
+# Licensed under the Apache License, Version 2.0 (see LICENSE).
+
+from __future__ import absolute_import
+
+import subprocess
+
+from testing.docker import skip_unless_docker
+from testing.pytest_utils.tmp import Tempdir
+
+
+@skip_unless_docker
+def test_sdist_extraction(
+    tmpdir,  # type: Tempdir
+    pex_project_dir,  # type: str
+):
+    # type: (...) -> None
+
+    assert (
+        b"/root/.cache/pex/installed_wheels/2/"
+        b"f0e26292130d3efebe48e40b10c5f9e79911ad507ccd2f02aea5793dea67abc0/"
+        b"pymongo-3.11.4-cp311-cp311-linux_x86_64.whl/pymongo/__init__.py\n"
+    ) == subprocess.check_output(
+        args=[
+            "docker",
+            "run",
+            "--rm",
+            "-v",
+            "{code}:/code".format(code=pex_project_dir),
+            "-w",
+            "/code",
+            "python:3.11.2-slim-bullseye",
+            "bash",
+            "-c",
+            "python -mpex pymongo==3.11.4 -- -c 'import pymongo; print(pymongo.__file__)'",
+        ]
+    )