Implement bulk key fetching and deleting for large queue without transaction #45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR #44
We want to reduce redis load by delete-queue command when the queue has a large number of tasks.
*a large number is about 10^6
I implemented following improvements:
add
--without-transactionoption to large queue deleteuse SScan instead of SMembers command to fetch task UIDs
use UnLink instead of Del command and bulk deleting keys by chunk size
WIP points
fixes #28