Merge pull request #3 from brummbar/handle-empty-responses

pfrenssen · web-flow · commit 3ea0b0844488 · 2018-08-14T21:25:17.000+03:00
Handle 200 OK responses with an empty or non-json body.
diff --git a/src/QueryResult.php b/src/QueryResult.php
@@ -78,7 +78,7 @@ public function hasError()
         // but the body of the response will contain the string "error" in the
         // "result" parameter.
         // @see https://github.com/matomo/matomo/issues/7293
-        return $this->isObject() && $this->parameterExists('result') && $this->get('result') === 'error';
+        return !$this->isObject() || $this->parameterExists('result') && $this->get('result') === 'error';
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -78,7 +78,7 @@ public function hasError()`
`78`	`78`	`// but the body of the response will contain the string "error" in the`
`79`	`79`	`// "result" parameter.`
`80`	`80`	`// @see https://github.com/matomo/matomo/issues/7293`
`81`		`- return $this->isObject() && $this->parameterExists('result') && $this->get('result') === 'error';`
	`81`	`+ return !$this->isObject() \|\| $this->parameterExists('result') && $this->get('result') === 'error';`
`82`	`82`	`}`
`83`	`83`
`84`	`84`	`/**`