Skip to content
This repository has been archived by the owner on Jun 27, 2020. It is now read-only.

Support extracting cover from guide #30

Open
Carmina16 opened this issue Dec 9, 2017 · 4 comments
Open

Support extracting cover from guide #30

Carmina16 opened this issue Dec 9, 2017 · 4 comments
Milestone

Comments

@Carmina16
Copy link

This file doesn't get its cover extracted:

coversample.epub.zip

@pgaskin
Copy link
Owner

pgaskin commented Dec 9, 2017

Thanks for reporting this issue. I'll look into it now.

@pgaskin pgaskin self-assigned this Dec 9, 2017
@pgaskin
Copy link
Owner

pgaskin commented Dec 9, 2017

OK. It seems like this is a problem with your epub file.


In content.opf line 10, the cover is defined as referencing the file with the id item2.

<meta name="cover" content="item2" />

In line 32, the file has the id cover.jpg, not item2.

<item href="Images/cover.jpg" id="cover.jpg" media-type="image/jpeg" />

This means that your epub is not referencing the cover correctly. Your epub can be fixed by changing line 32 to:

<item href="Images/cover.jpg" id="item2" media-type="image/jpeg" />

That should make BookBrowser pick up the cover correctly. Please tell me if it fixes your issue.

@Carmina16
Copy link
Author

The cover image is defined in <guide> and is extracted by every reader I have.

The BookBrowser should do the same, I believe.

@pgaskin
Copy link
Owner

pgaskin commented Dec 11, 2017

@Carmina16 OK, I see. I'll work on that soon.

@pgaskin pgaskin changed the title Cover fails to extract Support cover from guide Dec 11, 2017
@pgaskin pgaskin changed the title Support cover from guide Support extracting cover from guide Dec 11, 2017
@pgaskin pgaskin removed their assignment Feb 24, 2019
@pgaskin pgaskin added this to the v4.1.0 milestone Mar 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants