Fix Container Logging (#1919)

Author: pglombardo

.gitignore

@@ -663,5 +663,5 @@ storage/
 bin/*.rb
 
 /config/credentials/development.key
-
+/config/credentials/staging.key
 /config/credentials/production.key

config/defaults/settings.yml

@@ -913,8 +913,8 @@ default_locale: :en
 
 # Configure the logging verbosity of the application.
 #
-# Valid values are: debug, info, warn, error, fatal
-log_level: 'warn'
+# Valid values are: :debug, :info, :warn, :error, :fatal
+log_level: :warn
 
 # In containers, it is usually desired to log to stdout
 # instead of using log files (e.g. log/production.log).

config/environments/production.rb

@@ -54,21 +54,26 @@
   # Force all access to the app over SSL, use Strict-Transport-Security, and use secure cookies.
   config.force_ssl = ENV.key?("FORCE_SSL")
 
-  # Log to STDOUT by default
-  config.logger = ActiveSupport::Logger.new($stdout)
-    .tap { |logger| logger.formatter = Logger::Formatter.new }
-    .then { |logger| ActiveSupport::TaggedLogging.new(logger) }
-
-  # config.logger = Logger.new($stdout) if Settings.log_to_stdout
-  config.log_level = Settings.log_level ? Settings.log_level.downcase.to_sym : "error"
-
-  # Prepend all log lines with the following tags.
-  config.log_tags = [:request_id]
+  # Logging
+  config.logger = if ENV["RAILS_LOG_TO_STDOUT"].present? || Settings.log_to_stdout
+    # Log to STDOUT by default
+    ActiveSupport::Logger.new($stdout)
+      .tap { |logger| logger.formatter = Logger::Formatter.new }
+      .then { |logger| ActiveSupport::TaggedLogging.new(logger) }
+  else
+    ActiveSupport::TaggedLogging.new(Logger.new("log/production.log"))
+      .tap { |logger| logger.formatter = ::Logger::Formatter.new }
+      .then { |logger| ActiveSupport::TaggedLogging.new(logger) }
+  end
 
   # Info include generic and useful information about system operation, but avoids logging too much
   # information to avoid inadvertent exposure of personally identifiable information (PII). If you
   # want to log everything, set the level to "debug".
-  config.log_level = ENV.fetch("RAILS_LOG_LEVEL", "info")
+  # Obey settings.yml
+  config.log_level = Settings.log_level
+
+  # Prepend all log lines with the following tags.
+  config.log_tags = [:request_id]
 
   # Use a different cache store in production.
   # config.cache_store = :mem_cache_store
@@ -77,7 +82,7 @@
   # config.active_job.queue_adapter     = :resque
   # config.active_job.queue_name_prefix = "password_pusher_production"
 
-  config.action_mailer.perform_caching = false
+  config.action_mailer.perform_caching = true
 
   # Ignore bad email addresses and do not raise email delivery errors.
   # Set this to true and configure the email server for immediate delivery to raise delivery errors.
@@ -135,12 +140,6 @@
     end
   end
 
-  if ENV["RAILS_LOG_TO_STDOUT"].present? || Settings.log_to_stdout
-    logger = ActiveSupport::Logger.new($stdout)
-    logger.formatter = config.log_formatter
-    config.logger = ActiveSupport::TaggedLogging.new(logger)
-  end
-
   # If a user sets the allowed_hosts setting, we need to add the domain(s) to the list of allowed hosts
   if Settings.allowed_hosts.present?
     if Settings.allowed_hosts.is_a?(Array)

config/initializers/rack_attack.rb

@@ -913,8 +913,8 @@ default_locale: :en
 
 # Configure the logging verbosity of the application.
 #
-# Valid values are: debug, info, warn, error, fatal
-log_level: 'warn'
+# Valid values are: :debug, :info, :warn, :error, :fatal
+log_level: :warn
 
 # In containers, it is usually desired to log to stdout
 # instead of using log files (e.g. log/production.log).