File upload issue

[rucksman]

There seems to be an issue with file uploads. I configured my settings.yml in a way that for file pushes only 1 file is allowed. After choosing a file and clicking on "Push it" there is a yellow bar on top saying that only 1 file upload is allowed, which is what I wanted. I can see the file in /opt/PasswordPusher/storage. But no push is created. After changing max_file_uploads to 2 or more the push was created. So max_file_uploads=1 seems not to work.

I am running the latest docker image.

[github-actions]

Hello @rucksman, thanks for contributing to the Password Pusher community! We will respond as soon as possible.

[pglombardo]

Hi @rucksman - this might be due to a recent change. I'll take a look soon. As a work-around you could revert to the previous release...

[wedowhateverwewant]

Hi, just wanted to quickly chime in on this, I'm on v1.45.11 and limiting file uploads to 1 file works perfectly fine.

[pglombardo]

Hi @rucksman - I tested this locally and added a test to validate in #2612 but couldn't reproduce. Is this still happening and which browser are you using? Are there any errors in the Browser console?

Thanks @wedowhateverwewant - I realized I needed to add a test for this anyways.

[rucksman]

Sorry for the confusion, but I THOUGHT to use the latest Docker image. This is not true. As I did set show_version to false from the beginning, I was not aware of the exact version I am on. Although I always keep my images/containers up to date, I am not using the LATEST Docker image but the LATEST STABLE image which happens to be 1.45.10. So in this version the problem still exists, but most likely not in the latest version which is 1.46.1 which I did not test.

[pglombardo]

It might be a browser related issue. Which browser are you using?

Could you try another? And in incognito mode? And also check if there are any errors in the browser console.

[rucksman]

Maybe I was not clear enough, because I do not know why there should be a browser issue. In my docker compose file I am using the image: docker.io/pglombardo/pwpush:stable

This is of course the same image as this one here: https://hub.docker.com/layers/pglombardo/pwpush/stable/images/sha256-a19c79ad26aadd08fe98576664fcb44efe2d974144047d9d2f92a41f7f8863ab?context=explore

And this image is version 1.45.10. As per the release notes you fixed the bug in 1.45.11, so I am on a version that still has this bug. I could change of course to docker.io/pglombardo/pwpush:latest, but I guess that you tag the image "stable" for a reason, thats why I want to stick with it. If 1.45.11 oder 1.46.1 is considered stable, then you could of course push this version as stable image to the Docker hub.