fix: install in action dist directory

Author: ph-fritsche

src/util/install.ts

@@ -16,13 +16,18 @@ export function install(packages: string[], log: (msg: string) => void): Promise
     if (missing.length) {
         log(`Install ${JSON.stringify(missing)}`)
 
+        // if logging function is core.info, we're in debug/test
+        const isDebug = log === info
+
         const args = ['install', '--no-save']
-        if (log !== info) { // if logging function is core.info, we're in debug/test
+        if (!isDebug) {
             args.push('--silent')
         }
         args.push('--', ...missing)
 
-        return spawn('npm', args, {})
+        return spawn('npm', args, {
+            cwd: __dirname,
+        })
     }
 
     return Promise.resolve('')

test/util/install.ts

@@ -1,13 +1,15 @@
+import { SpawnOptions } from 'child_process'
+import path from 'path'
 import { install } from '../../src/util/install'
 
 let resolveMock: jest.MockedFunction<(name: string) => string>
 jest.mock('../../src/util/resolve', () => ({
     resolve: (name: string) => resolveMock(name),
 }))
 
-let spawnMock: jest.MockedFn<(cmd: string, args: string[]) => Promise<string>>
+let spawnMock: jest.MockedFn<(cmd: string, args: string[], opt: SpawnOptions) => Promise<string>>
 jest.mock('../../src/util/spawn', () => ({
-    spawn: (cmd: string, args: string[]) => spawnMock(cmd, args),
+    spawn: (cmd: string, args: string[], opt: SpawnOptions) => spawnMock(cmd, args, opt),
 }))
 
 test('skip present modules', async () => {
@@ -42,3 +44,15 @@ test('install missing modules', async () => {
     expect(spawnMock.mock.calls[0][1]).toContain('bar')
     expect(log).toEqual([expect.stringContaining('Install ["foo","bar"]')])
 })
+
+test('install in dist', async () => {
+    spawnMock = jest.fn()
+
+    await install(['foo'], () => undefined)
+
+    expect(spawnMock).toBeCalledTimes(1)
+    expect(spawnMock.mock.calls[0][2]).toEqual(expect.objectContaining({
+        // In test this should be the directory of the `install` util
+        cwd: path.resolve(__dirname, '../../src/util'),
+    }))
+})