feat: hide internal stack entries

Author: ph-fritsche

src/conductor/TestRun/TestSuite.ts

@@ -11,6 +11,7 @@ import { createTestElements } from './createTestElements'
 import { CoverageMapData } from './TestCoverage'
 import { TestHook } from './TestHook'
 import { TestRunState } from './enum'
+import { XError } from '../../error/XError'
 
 export class TestSuiteStack extends TestNodeStack {
     static create(
@@ -175,10 +176,13 @@ export class TestSuite extends TestNodeInstance {
             throw new Error(`Can not add error for node #${String(data.nodeId)}`)
         }
 
-        node.errors.add(new TestError(
+        const error = new TestError(
             data.error,
             data.hook && new TestHook(data.hook.type, data.hook.index, data.hook.name, data.hook.cleanup),
-        ))
+        )
+        this.setStackEntriesMain(error)
+
+        node.errors.add(error)
     }
 
     private reportResult(data: TestResultData) {
@@ -189,7 +193,23 @@ export class TestSuite extends TestNodeInstance {
             throw new Error(`Can not add result for node #${data.nodeId}`)
         }
 
-        node.result.set(new TestResult(data.type, data.error, data.duration))
+        const result = new TestResult(data.type, data.error, data.duration)
+        if (result.error) {
+            this.setStackEntriesMain(result.error)
+        }
+
+        node.result.set(result)
+    }
+
+    protected setStackEntriesMain(error: XError) {
+        if (error.stackEntries) {
+            const i = error.stackEntries.findLastIndex(
+                e => e.file === this.url,
+            )
+            if (i >= 0) {
+                error.stackEntriesMain = i
+            }
+        }
     }
 
     protected _coverage?: CoverageMapData

src/error/XError.ts

@@ -35,6 +35,8 @@ export class XError implements Error {
 
     text: string
     stackEntries?: StackEntry[]
+    /** Index of the "entry point" */
+    stackEntriesMain?: number
 }
 
 function forEach<T, R>(
@@ -66,23 +68,26 @@ function* genStackEntries(stack: string) {
         }
         const raw = l.substring(pre.length)
 
-        const m0 = raw.match(/(?<name>.+) \((?<file>[^)]+):(?<line>\d+):(?<column>\d+)\)$/)
+        const m0 = raw.match(/(?<async>async )?(?<name>.+) \((?<file>[^)]+):(?<line>\d+):(?<column>\d+)\)$/)
         if (m0?.groups) {
             yield new StackEntry(
                 raw,
                 m0.groups.file,
                 {line: Number(m0.groups.line), column: Number(m0.groups.column)},
                 m0.groups.name,
+                !!m0.groups.async,
             )
             continue
         }
 
-        const m1 = raw.match(/(?<file>.*):(?<line>\d+):(?<column>\d+)$/)
+        const m1 = raw.match(/(?<async>async )?(?<file>.*):(?<line>\d+):(?<column>\d+)$/)
         if (m1?.groups) {
             yield new StackEntry(
                 raw,
                 m1.groups.file,
                 {line: Number(m1.groups.line), column: Number(m1.groups.column)},
+                undefined,
+                !!m1.groups.async,
             )
             continue
         }
@@ -105,6 +110,7 @@ export class StackEntry {
         readonly file?: string,
         readonly position?: Position,
         readonly name?: string,
+        readonly async: boolean = false,
     ) {
         this.resolved = new ResolvedValue<SourceLocation>({file, position, name})
     }
@@ -115,15 +121,16 @@ export class StackEntry {
     ) {
         const e = this.resolved.get()
 
+        const async = this.async ? 'async ' : ''
         const pos = e.position ? `:${e.position.line}:${e.position.column}` : ''
         if (useUrl && e.url && e.name) {
-            return `${e.name} (${e.url})`
+            return `${async}${e.name} (${e.url})`
         } else if (useUrl && e.url) {
-            return `${e.url}`
+            return `${async}${e.url}`
         } else if (e.name && e.file) {
-            return `${e.name} (${e.file}${pos})`
+            return `${async}${e.name} (${e.file}${pos})`
         } else if (e.file) {
-            return `${e.file}${pos}`
+            return `${async}${e.file}${pos}`
         }
         return this.raw
     }

src/ui/cli/Error.tsx

@@ -41,7 +41,7 @@ export function XErrorComponent({
                 <Text color="redBright">{t}</Text>
             </Line>
         ))}
-        {error.stackEntries?.map((entry, i, a) => (
+        {error.stackEntries?.map((entry, i, a) => ((error.stackEntriesMain === undefined || i <= error.stackEntriesMain) && (
             <Line key={`stack-${i}`}
                 // If overflowX is set, Links are truncated although the box measurements are correct.
                 overflow="visible"
@@ -52,6 +52,6 @@ export function XErrorComponent({
                 }</Text>)}
                 <StackEntryText entry={entry}/>
             </Line>
-        ))}
+        )))}
     </Block>
 }