Skip to content

Commit dcdb29b

Browse files
committed
test(NodeImportReolver): remove assertion for absolute specifiers in network modules
1 parent 571bd7f commit dcdb29b

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

src/loader/ImportResolver.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -239,6 +239,8 @@ export async function createNodeImportResolver(catchErrors = true): Promise<Impo
239239

240240
try {
241241
type R = (s: string, i: string) => Promise<string>|string
242+
// `import.meta.resolve` can cause an uncaught error for `Assertion failed: file_url`
243+
// See https://github.com/nodejs/node/issues/55518
242244
return await (import.meta.resolve as R)(specifier, String(importerUrl))
243245
} catch(e) {
244246
if (catchErrors) {

test/loader/ImportResolver.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,9 @@ test('resolve per node import', async () => {
154154

155155
expect(await resolve('already-resolved', 'typescript', new URL(cwd + '/foo.js'), [])).toBe(undefined)
156156

157-
expect(await resolve(undefined, 'typescript', new URL('http://example.org/foo.js'), [])).toBe(undefined)
157+
// `import.meta.resolve` can cause an uncaught error for `Assertion failed: file_url`
158+
// See https://github.com/nodejs/node/issues/55518
159+
// expect(await resolve(undefined, 'typescript', new URL('http://example.org/foo.js'), [])).toBe(undefined)
158160
})
159161

160162
test('resolve per node require', async () => {

0 commit comments

Comments
 (0)