Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_write_walks_to_disk crashes for the non-str walk items #98

Open
luav opened this issue Aug 5, 2019 · 2 comments
Open

_write_walks_to_disk crashes for the non-str walk items #98

luav opened this issue Aug 5, 2019 · 2 comments

Comments

@luav
Copy link

luav commented Aug 5, 2019

Walks persistence fails for the non-str walk items (in case the module is used as a library from https://github.com/eXascaleInfolab/HARP with int walk items).

  File "/usr/local/lib/python3.5/dist-packages/deepwalk-1.0.3-py3.5.egg/deepwalk/walks.py", line 85, in write_walks_to_disk
    for file_ in executor.map(_write_walks_to_disk, args_list):
  File "/usr/lib/python3.5/concurrent/futures/_base.py", line 556, in result_iterator
    yield future.result()
  File "/usr/lib/python3.5/concurrent/futures/_base.py", line 405, in result
    return self.__get_result()
  File "/usr/lib/python3.5/concurrent/futures/_base.py", line 357, in __get_result
    raise self._exception
TypeError: sequence item 0: expected str instance, int found
@GTmac
Copy link
Collaborator

GTmac commented Aug 8, 2019

It seems that the problem is with HARP -- we assume that walk items are all strings in DeepWalk.

@luav
Copy link
Author

luav commented Aug 9, 2019

@GTmac Up to you. In theory, the type of walk items should not affect the execution: the graph nodes are just some objects (more compact in case of numerical ids than text strings). This small fix does not affect the persistence of the walk items having str type, it just makes possible to persist the walk items of any other type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants